Osclass icon indicating copy to clipboard operation
Osclass copied to clipboard

The ability to add a custom field - number type

Open alex7070m opened this issue 4 years ago • 7 comments

Is your feature request related to a problem? Please describe.

Hello! It would be nice if the admin could add a custom field - type number. This is necessary for example to display the proposed salary in the "Job" category and the ability to search by this parameter (the proposed salary).

alex7070m avatar Aug 10 '20 07:08 alex7070m

I have some plans with the custom field in future, I am sure that will has this kind of field. It is hard to comment when I am pretty much all occupied with other osclass stuff right now. The current priority is to finalize the current dev branch and launch a new beta release of osclass.

navjottomer avatar Aug 12 '20 20:08 navjottomer

@navjottomer Any new plans for custom fields? I would like to add reordering support, and maybe some new types like mentioned number type.

patriksh avatar Oct 08 '21 08:10 patriksh

Currently working on a commit for translation support, I'll think any commit from your side will create conflict and vice versa. If you can wait that will be good, it won't take much time or we have to manually resolve the conflicts.

navjottomer avatar Oct 08 '21 08:10 navjottomer

Took a bit more time, You can go-ahead now

navjottomer avatar Oct 20 '21 20:10 navjottomer

@navjottomer The latest develop branch has some problem with extending custom fields.

When I click on "+" button to show a form to add a field, it just freezes and my debug log is spammed with this:

Undefined index: s_name in osclass-mindstellar/oc-includes/osclass/classes/model/Field.php on line no 137 Error Code:8

In the end apache just crashes.

Once you fix that, I'm ready to do the PR for number type.

patriksh avatar Nov 19 '21 15:11 patriksh

Can close this? Or we're just adding labels now?

patriksh avatar Dec 27 '21 12:12 patriksh

It's better to have these labels till not merged in main branch. Easier to know what fixed in developer branch.

On Mon, 27 Dec, 2021, 5:37 pm Defected, @.***> wrote:

Can close this? Or we're just adding labels now?

— Reply to this email directly, view it on GitHub https://github.com/mindstellar/Osclass/issues/266#issuecomment-1001535114, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIDQSMHQFIAQT5T2WSR2W3UTBI45ANCNFSM4PZVY2ZQ . You are receiving this because you were mentioned.Message ID: @.***>

navjottomer avatar Dec 27 '21 13:12 navjottomer