mindsdb_sql icon indicating copy to clipboard operation
mindsdb_sql copied to clipboard

Remove to_tree method from AST classes

Open ea-rus opened this issue 1 year ago • 2 comments

Do we use to_tree method for any purpose?

For now it is additional code in every ASTNode class which looks like is not used

ea-rus avatar Sep 21 '23 11:09 ea-rus

Hey hii. I would like to work on this issue.

i have gone through the code, I saw that we are to_tree a lot in test cases, If we remove to_tree method, then most of the test cases would get affected.

so little confused what to do next, do you still want me to remove to_tree method?

Thank you, Sandeep Kumar

BattiniSandeep avatar Oct 12 '23 18:10 BattiniSandeep

Hey, I think we can remove to_tree in tests too. Don't check result of this method if it don't exist anymore

ea-rus avatar Oct 13 '23 11:10 ea-rus