mindsdb icon indicating copy to clipboard operation
mindsdb copied to clipboard

Created a unittest for Jira integration

Open Sekhar-Kumar-Dash opened this issue 1 year ago • 6 comments

Description

This PR creates a unittest for Jira Handler

Type of change

  • [X] ⚡ New feature (non-breaking change which adds functionality)

Verification Process

To ensure the changes are working as expected:

  • [ ] Test Location: Specify the URL or path for testing.
  • [ ] Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • [x] I have attached a brief loom video or screenshots showcasing the new functionality or change. image

Checklist:

  • [x] My code follows the style guidelines(PEP 8) of MindsDB.
  • [x] I have appropriately commented on my code, especially in complex areas.
  • [ ] Necessary documentation updates are either made or tracked in issues.
  • [x] Relevant unit and integration tests are updated or added.

Sekhar-Kumar-Dash avatar Mar 15 '24 17:03 Sekhar-Kumar-Dash

hey @MinuraPunchihewa please review this PR.

Sekhar-Kumar-Dash avatar Mar 15 '24 17:03 Sekhar-Kumar-Dash

Can we please move the tests from /tests to the handler folder for this and the other similar PRs? See the mysql handler for an example of where to put them. We're trying to make the handlers more self contained :)

hamishfagg avatar Mar 17 '24 22:03 hamishfagg

Can we please move the tests from /tests to the handler folder for this and the other similar PRs? See the mysql handler for an example of where to put them. We're trying to make the handlers more self contained :)

hey @hamishfagg actually i was told to put this test files in /test folder

Sekhar-Kumar-Dash avatar Mar 18 '24 05:03 Sekhar-Kumar-Dash

Hey @hamishfagg, When @Sekhar-Kumar-Dash reached out to me, I asked him to place the tests in the /tests directory. I apologize if this was an incorrect instruction. Have we decided to place the tests for handlers in their own folders? CC: @ZoranPandovski

MinuraPunchihewa avatar Mar 18 '24 07:03 MinuraPunchihewa

Yeah that is the plan moving forward - it makes it much easier to find tests relevant to a handler, and makes it easier to execute tests based on changed files. Thanks

hamishfagg avatar Mar 18 '24 22:03 hamishfagg

Thank you for this info, @hamishfagg.

MinuraPunchihewa avatar Mar 19 '24 05:03 MinuraPunchihewa