mindsdb icon indicating copy to clipboard operation
mindsdb copied to clipboard

Build Rockset Integration

Open alissatroiano opened this issue 1 year ago • 12 comments

Fixes #3569

Please describe what changes you made, in as much detail as possible

  • Create Rockset handler in integrations dir

alissatroiano avatar Oct 31 '22 17:10 alissatroiano

Hey this wasn't working or :) ?

ZoranPandovski avatar Nov 01 '22 14:11 ZoranPandovski

Hey this wasn't working or :) ?

Honestly, I wasn't sure if it was and I didn't want you guys to think I was trying to push code through the finish line for hacktoberfest lol

I took my time with this one and it's actually passing all the checks. I'd definitely appreciate the feedback if you review it

alissatroiano avatar Nov 01 '22 16:11 alissatroiano

@ZoranPandovski I still need to test this one, but I was experiencing build errors https://github.com/mindsdb/mindsdb/issues/3965 - I got it running now so I'll test it

alissatroiano avatar Nov 01 '22 18:11 alissatroiano

Being working on this on my local system. How is it going @alissatroiano

Tes-program avatar Nov 02 '22 02:11 Tes-program

Ooooo you are using the MYSQLHandler

Tes-program avatar Nov 02 '22 02:11 Tes-program

Ooooo you are using the MYSQLHandler

yes, did you use the rockset dependency? I am wondering if that might be better

alissatroiano avatar Nov 02 '22 20:11 alissatroiano

Being working on this on my local system. How is it going @alissatroiano

It's not working yet.. something in my connection string is wrong. How about you?

alissatroiano avatar Nov 03 '22 00:11 alissatroiano

Ooooo you are using the MYSQLHandler

yes, did you use the rockset dependency? I am wondering if that might be better

Yeah, I did actually but I couldn't get it working. Sigh maybe i should test your connection

Tes-program avatar Nov 05 '22 08:11 Tes-program

Ooooo you are using the MYSQLHandler

yes, did you use the rockset dependency? I am wondering if that might be better

Yeah, I did actually but I couldn't get it working. Sigh maybe i should test your connection

Go for it. I was pretty sick last week - weird sinus infection thing (not covid luckily), and I had to rest... I'm not 100% sure how to test it manually but I wrote some automated tests that I'm definitely going to take another look now that I feel better. I'll let you know how it goes

alissatroiano avatar Nov 08 '22 04:11 alissatroiano

Hey this wasn't working or :) ?

well, the unittests I just refactored and ran in the CLI are working as of now...

alissatroiano avatar Nov 08 '22 22:11 alissatroiano

Ooooo you are using the MYSQLHandler

yes, did you use the rockset dependency? I am wondering if that might be better

Yeah, I did actually but I couldn't get it working. Sigh maybe i should test your connection

Go for it. I was pretty sick last week - weird sinus infection thing (not covid luckily), and I had to rest... I'm not 100% sure how to test it manually but I wrote some automated tests that I'm definitely going to take another look now that I feel better. I'll let you know how it goes

I hope you are better now? Sorry i am busy from school and all and i can see you have pushed new changes.

Tes-program avatar Nov 11 '22 17:11 Tes-program

Ooooo you are using the MYSQLHandler

yes, did you use the rockset dependency? I am wondering if that might be better

Yeah, I did actually but I couldn't get it working. Sigh maybe i should test your connection

Go for it. I was pretty sick last week - weird sinus infection thing (not covid luckily), and I had to rest... I'm not 100% sure how to test it manually but I wrote some automated tests that I'm definitely going to take another look now that I feel better. I'll let you know how it goes

I hope you are better now? Sorry i am busy from school and all and i can see you have pushed new changes

Ah, got it. Well school definitely comes first, so good job staying focused on that.

I'm almost back to 100%, but it's not happening as quickly as I'd like of coursr - thanks for asking.

Yea I did some refactoring and ran those Python unit tests... no failures, so that's good and all the GH action checks are passing...

I was out running errands today - I'll add some screenshots of the tests and expand the content in this PR. Keep an eye out for updates. Have a great weekend!

alissatroiano avatar Nov 11 '22 20:11 alissatroiano