mindsdb icon indicating copy to clipboard operation
mindsdb copied to clipboard

add more openai models for agents

Open dusvyat opened this issue 7 months ago • 1 comments

Description

Please include a summary of the change and the issue it solves.

Fixes #issue_number

Type of change

(Please delete options that are not relevant)

  • [ ] 🐛 Bug fix (non-breaking change which fixes an issue)
  • [ ] ⚡ New feature (non-breaking change which adds functionality)
  • [ ] 📢 Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • [ ] 📄 This change requires a documentation update

Verification Process

To ensure the changes are working as expected:

  • [ ] Test Location: Specify the URL or path for testing.
  • [ ] Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • [ ] I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • [ ] My code follows the style guidelines(PEP 8) of MindsDB.
  • [ ] I have appropriately commented on my code, especially in complex areas.
  • [ ] Necessary documentation updates are either made or tracked in issues.
  • [ ] Relevant unit and integration tests are updated or added.

dusvyat avatar Jun 05 '25 16:06 dusvyat

Review Summary

🏷️ Draft Comments (1)

Skipped posting 1 drafted comments based on your review threshold. Feel free to update them here.

mindsdb/interfaces/agents/constants.py (1)

10-24: OPEN_AI_CHAT_MODELS is defined as a tuple but is not sorted, which can slow down membership checks if used frequently; consider using a set for O(1) lookups or sorting for readability.

Scores:

  • Production Impact: 1
  • Fix Specificity: 5
  • Urgency Impact: 1
  • Total Score: 7

Reason for filtering: The comment addresses a minor performance optimization with minimal production impact, provides a clear fix, but the urgency is very low. The total score does not meet the required threshold for inclusion.

Analysis: Changing a tuple to a set for O(1) lookups is a minor optimization and unlikely to cause production issues. The fix is clear, but the urgency and impact are both very low, resulting in a low total score.