lightwood icon indicating copy to clipboard operation
lightwood copied to clipboard

Day/hour/etc encoding for the ORDER BY column

Open tomhuds opened this issue 2 years ago • 1 comments

Often additional features proposed to users include day_of_week, weekend, hour_of_day etc.

In the encoding of the time variable, could we add these columns as additional inputs?

tomhuds avatar Jul 19 '22 21:07 tomhuds

Nice timing, I was actually trying this on #937 which wrongly figures as merged but is very much WIP. Last tests indicated worse performance, but this is counterintuitive so I wanted to try and give it another go.

EDIT: It's not a full coverage of the things mentioned in OP, e.g.weekend as such is not a new binary column that gets added, rather just day_of_week and other descriptors according to the DatetimeEncoder logic.

EDIT 2: List of things to try:

  • day_of_year
  • day_of_week
  • hour_of_day
  • is_weekend
  • quarter_of_year
  • month_of_year
  • year
  • week_of_year

paxcema avatar Jul 19 '22 21:07 paxcema

Closing. Should be solved by the sinusoidal datetime encoder. Will decide with #1157 whether to mark it as default.

paxcema avatar Jun 23 '23 16:06 paxcema