contex icon indicating copy to clipboard operation
contex copied to clipboard

Published 20 hours ago • verified publisher icon mindok

fix bug with colors and add numerous options

Open DaTrader opened this issue 1 year ago • 5 comments

Bug fixes

  • Fixed logic with choosing candle/bar color based on open/close
  • Fixed shadow style

Enhancements

  • Added bull, bear, shadow colors options (instead of having them hardcoded)
  • Added zoom levels (so far only body width is affected)
  • Added optional body border for candles
  • Added crispEdges rendering option (looks way better when SVG container size and SVG size match 1:1)
  • Made colorized bars optional

Code housekeeping

  • Added specs to all functions in ohlc.ex (except for protocol implementation ones)
  • Improved readability by removing pattern matching from function heads
  • Further improved readability through use of Extructure library

DaTrader avatar Jan 06 '24 22:01 DaTrader

@mindok Saw your comment on the elixirforum but am not sure what more should I do. Can't you simply approve this "workflow" as it states it's awaiting your approval.

If not, then please guide me step by step. For the reference, I forked your project and committed to the ohlc branch and then created this PR here to merge it into your ohlc branch.

DaTrader avatar Jan 13 '24 10:01 DaTrader

@DaTrader - just saw this. For some reason I wasn't notified of the PR creation. I created a new one to include my original commits so we can merge straight into master. I'll move your comments across. If you're ok with that, I'll close this one.

mindok avatar Jan 13 '24 21:01 mindok

sure

On Sat, Jan 13, 2024, 23:00 mindok @.***> wrote:

@DaTrader https://github.com/DaTrader - just saw this. For some reason I wasn't notified of the PR creation. I created a new one to include my original commits so we can merge straight into master. I'll move your comments across. If you're ok with that, I'll close this one.

— Reply to this email directly, view it on GitHub https://github.com/mindok/contex/pull/88#issuecomment-1890778606, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHGBEC26AKY27HODDYP4LN3YOL7WHAVCNFSM6AAAAABBP3M3KCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJQG43TQNRQGY . You are receiving this because you were mentioned.Message ID: @.***>

DaTrader avatar Jan 15 '24 21:01 DaTrader

@mindok is this still active? It seems it is quite useful and stable esp combined with liveview, so opening up maintenance may help or asking for sponsorship etc... oss can be hard.

inoas-nbw avatar Mar 22 '24 07:03 inoas-nbw

Hi @inoas-nbw - thanks for the prompt... you are right - OSS can be hard when other aspects of life get a little crazy. I'll merge this one, the barchart PR and the OHLC/candles in one session - @DaTrader has done a great job on the OHLC work. Thanks for the nudge re: maintainers - I'll put something in the readme and announce on elixir forums to see if anyone is happy to help out with merging / reviews etc. I need to ask the community a couple of questions re: direction so it's a good time.

mindok avatar Mar 25 '24 03:03 mindok