python-mocket icon indicating copy to clipboard operation
python-mocket copied to clipboard

Published 20 hours ago • verified publisher icon mindflayer

Begin mypy type-checking

Open Kilo59 opened this issue 9 months ago • 1 comments

Begin minimal type-checking of the codebase as part of the effort to export type hints.

  • #203
  • Add make types item
  • Add types to make tests step that runs in ci
  • Type checking of select modules
    • utils
    • compat
    • exceptions

Will followup this up to add annotations to remaining modules.

Kilo59 avatar Apr 26 '24 14:04 Kilo59

I am sorry it took a while, I had to find some time to invest in the CI for being able to run tests on external PRs. It looks like mypy is not happy about the way I am dealing with location when made of just a str. I'll come back to you with a fix.

mindflayer avatar May 08 '24 10:05 mindflayer

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 08 '24 10:05 sonarqubecloud[bot]

Coverage Status

coverage: 98.59% (-0.2%) from 98.818% when pulling f0e5442fb4512f9f476f1f8b2a4fb7663c39b4ab on Kilo59:main into 389d95e657772a37d634088d50138b1faa19bf0b on mindflayer:main.

coveralls avatar May 08 '24 10:05 coveralls

Merged, we still lack a pre-commit hook for mypy.

mindflayer avatar May 08 '24 10:05 mindflayer