min icon indicating copy to clipboard operation
min copied to clipboard

feat(bitwarden): added field for server url during setup for self-hosted servers and others

Open UnKnoWn-Consortium opened this issue 2 years ago • 6 comments

feat(bitwarden): added field for server url during setup for self-hosted servers fix(bitwarden): fixed confusing cache logic that does not cache credential request responses properly refactor(prompt): retrofitted the createPrompt function with promise refactor(prompt): updated createPrompt usage for the promise retrofit refactor: unwrapped AutofillSetup as individual functions and exported the initialize function that is used externally refactor: unwrapped PasswordManagers as individual functions and exported functions that are used externally refactor: replaced some usages of var with let and const

UnKnoWn-Consortium avatar May 25 '23 19:05 UnKnoWn-Consortium

This seems reasonable from reading over it; can you explain "fixed confusing cache logic that does not cache credential request responses properly"?

PalmerAL avatar May 29 '23 17:05 PalmerAL

@PalmerAL In the original code, the cache list lastCallList for a domain is set to a promise instead of the suggestion returned from the password manager. https://github.com/minbrowser/min/blob/5bd1544eb1bbd4ea7913d25da26f4395bc177d85/js/passwordManager/bitwarden.js#L87

UnKnoWn-Consortium avatar May 29 '23 19:05 UnKnoWn-Consortium

@PalmerAL Thanks for bringing us multi-window support. ~~I will resolve the conflict asap.~~ Done.

UnKnoWn-Consortium avatar May 29 '23 19:05 UnKnoWn-Consortium

@PalmerAL Sorry to ping. Conflict resolved now.

UnKnoWn-Consortium avatar Jun 09 '23 11:06 UnKnoWn-Consortium

Sorry, I haven't had time to test this. Will do in the next few days.

PalmerAL avatar Jun 12 '23 04:06 PalmerAL

@PalmerAL Sorry my fault. Please take your time.

UnKnoWn-Consortium avatar Jun 12 '23 22:06 UnKnoWn-Consortium