min icon indicating copy to clipboard operation
min copied to clipboard

Lack of control over High Contrast theming, and theme settings confusion that follows

Open fbck opened this issue 2 years ago • 0 comments

min 1.25.1, Windows 10 1809

By default, min adheres to system's high contrast theme setting, and shows browser interface in a high contrast theme. Websites also get their themes adjusted to system's high contrast theme. Changing "Enable dark mode" setting doesn't seem to do anything (i assume it's for browser interface?), and neither does ticking "Enable site theme" on and off (does it just change tab color into site colors?). (There doesn't appear to be a way to control theming of websites themselves, something that would be controlled with "Auto Dark Mode" flag in chromium.) There is a launch parameter for apps that use chromium that can change whether the app is adhering to system's high contrast theme, or ignores it - "--disable-features=ForcedColors". When launched with this flag, min shows browser interface in light theme. But changing "Enable dark mode" setting to 'Always' doesn't switch browser interface to a dark theme.

To me, this seems like a lack of descriptiveness on some existing appearance controls, and a lack of some other appearance controls. Dark mode setting could be more clear about what parts it applies to - is it just browser interface, or does it control website theming? Some browsers can adjust site themes, changing them into dark mode (including this one, the settings are just not exposed to user), so it wouldn't be too farfetched of an assumption to make. Enable site theme setting could be more clear about what the "site theme" is - is it theming the website, or does it do something else? would it be changing site theme into dark mode, when combined with it? these two settings are also close together, so it could be assumed. it's not exactly straightforward that this is just the "tab color" setting. (is it?) There's no setting that would let user control whether the browser would use system's high contrast theme or ignore it, and just use a theme set by user. It's good that the browser is adhering to system's high contrast theme, but sometimes, app's own dark theme might look good enough (or better in its own way), and some user interfaces set to high contrast can look odd and unfinished (min doesn't seem to be straight up unusable, but there are some odd bars in Tasks view and overall lack of highlights on hover), plus when it's a browser, it's going to auto-apply a high contrast theme to websites, which may be unwanted. It would be nice to have a 'Change website theme to dark mode' setting, just to make it available to users, and to let them control what's gonna happen to website themes when dark mode or high contrast mode is on.

fbck avatar Sep 22 '22 10:09 fbck