min icon indicating copy to clipboard operation
min copied to clipboard

Published 20 hours ago • verified publisher icon minbrowser

Google search suggestions

Open flightmansam opened this issue 2 years ago • 6 comments

Added search url (for english only). Tentatively disabled search engine check in instantAnswerPlugin

flightmansam avatar Aug 22 '22 05:08 flightmansam

TODO: Decide whether instantAnswerPlugin needs to fetch a preferences option to always provide instant answers using DDG even if the default search engine isn't DDG.

flightmansam avatar Aug 22 '22 05:08 flightmansam

@PalmerAL Is this okay to merge?

flightmansam avatar Feb 13 '23 05:02 flightmansam

I don't want to use the Google URL unless they have an official API we can use that they won't try to block. We could make this an option when you set a custom search engine though.

PalmerAL avatar Feb 15 '23 08:02 PalmerAL

Is any telemetry being sent to google at this point?

gribanoveu avatar Jul 16 '24 15:07 gribanoveu

Not any more than manually putting in the URL in any browser.

flightmansam avatar Jul 16 '24 23:07 flightmansam

Oh, I'm realizing I never followed up on the DDG part of this PR, sorry. I believe the original reason for that restriction was due to a restriction in DDGs API terms, although I can't find anything supporting that anymore. They've since deprecated the API entirely and deleted all the documentation, so we really should figure out an alternative to use; I'm not sure at the moment what that would be though.

PalmerAL avatar Jul 22 '24 23:07 PalmerAL