Running with Jupyter

[karlglazebrook]

Hi there,

I thought Min might be a good browser to try with Jupyter notebooks. (https://jupyter.org), being minimal

However the menu to open a new notebook seems to block. See screenshots, instead of the notebook page it gives 'about:blank#blocled'

Any ideas? I could not find anything in the settings. I tried turning off the ad blocker

Karl

Clicking on the menu:

After:

Obviously one would have to install Jupyter to reproduce this... I don't know what javascript function is being blocked here so sorry this bug report is not that helpful but I thought I would let you know.

[djtech-dev]

try disabling / enabling the Min's adblocker

[PalmerAL]

I spent some time looking into this. Jupyter notebook does this:

var w = window.open(undefined, '_blank')

We receive that event here, and it looks like this:

[1] {
[1]   url: 'about:blank#blocked',
[1]   frameName: '',
[1]   features: '',
[1]   disposition: 'foreground-tab',
[1]   referrer: {
[1]     url: 'http://localhost:8888/',
[1]     policy: 'strict-origin-when-cross-origin'
[1]   },
[1]   postBody: undefined
[1] }

The problem is that we block any requests to open a new window that don't have features set. The reason for that is a workaround for a different bug: #1835; when you shift+cmd+click on a link, we get an identical window open event:

[1] {
[1]   url: 'about:blank#blocked',
[1]   frameName: '',
[1]   features: '',
[1]   referrer: { url: '', policy: 'strict-origin-when-cross-origin' },
[1]   postBody: undefined,
[1]   disposition: 'foreground-tab'
[1] }

But allowing that makes Electron directly open a new popup window without allowing us to intercept it and open a new tab, which isn't what we want.

So I think unless we come up with a better workaround to the other bug, we're stuck with this. The jupyter menu still creates a file, and you can go back to the file list and click on it and it will open, so it's still usable mostly.

[karlglazebrook]

Perhaps file an issue with the Jupyter people about features being blank?