RxGoogleMaps icon indicating copy to clipboard operation
RxGoogleMaps copied to clipboard

2.x - Add support for RXJava 2.0

Open defer opened this issue 7 years ago • 4 comments

This is an abi-breaking change. The behavior is the same with the exception of methods that used to return Observable<Void> now return Observable<Boolean> because null emissions are not supported anymore.

As for compatibility, most projects supporting both 1.x and 2.x are keeping separate branches and keeping separate package names.This patchset does not change the package name, but it may go in that direction in the future.

defer avatar May 01 '17 10:05 defer

Codecov Report

Merging #11 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #11   +/-   ##
=========================================
  Coverage     98.97%   98.97%           
- Complexity        0       66   +66     
=========================================
  Files            25       25           
  Lines           195      195           
=========================================
  Hits            193      193           
  Misses            2        2
Impacted Files Coverage Δ Complexity Δ
...n/java/com/sdoward/rxgooglemap/CameraMoveFunc.java 100% <100%> (ø) 2 <2> (+2) :arrow_up:
...com/sdoward/rxgooglemap/CameraMoveStartedFunc.java 100% <100%> (ø) 2 <2> (+2) :arrow_up:
...om/sdoward/rxgooglemap/GroundOverlayClickFunc.java 100% <100%> (ø) 2 <2> (+2) :arrow_up:
...om/sdoward/rxgooglemap/CameraMoveCanceledFunc.java 100% <100%> (ø) 2 <2> (+2) :arrow_up:
...ava/com/sdoward/rxgooglemap/PolylineClickFunc.java 100% <100%> (ø) 2 <2> (+2) :arrow_up:
...ain/java/com/sdoward/rxgooglemap/POIClickFunc.java 100% <100%> (ø) 2 <2> (+2) :arrow_up:
...n/java/com/sdoward/rxgooglemap/CameraIdleFunc.java 100% <100%> (ø) 2 <2> (+2) :arrow_up:
...ain/java/com/sdoward/rxgooglemap/MapClickFunc.java 100% <100%> (ø) 2 <2> (+2) :arrow_up:
...m/sdoward/rxgooglemap/InfoWindowLongClickFunc.java 100% <100%> (ø) 2 <2> (+2) :arrow_up:
...va/com/sdoward/rxgooglemap/CameraPositionFunc.java 100% <100%> (ø) 2 <2> (+2) :arrow_up:
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8d91cc1...9fe1f21. Read the comment docs.

codecov-io avatar May 01 '17 17:05 codecov-io

Thanks for this. I will take a look at the weekend and give feedback/merge. Also sorry for the delay.

sdoward avatar Jun 09 '17 00:06 sdoward

hi, developer, is this still under developing/ maintain?

shingz96 avatar Sep 29 '17 20:09 shingz96

@defer would you be interested in taking ownership of this lib? I don't have the tie to maintain and I think it can be useful for others.

sdoward avatar Dec 17 '17 21:12 sdoward