Daniel Mendler

Results 809 comments of Daniel Mendler

@astoff What do you think about downloading mathjax from a trusted source if not already available? It could be downloaded and the hardcoded hash could be checked: https://packages.debian.org/source/bookworm/mathjax http://deb.debian.org/debian/pool/main/m/mathjax/mathjax_2.7.9+dfsg.orig.tar.xz d81378042cf3773fa5bd02954562e96c...

Thanks. I think that's fine. At least one can now decide to opt-out if mathjax is not needed.

I don't think this is a good idea. Candidates should be copied as is (except for invisible tofus used by Consult).

Oh, it is over two years ago that I contributed this. I don't remember any of the details. I never had problems with it. But by inspection I am not...

I tried changing the code above, and unfortunately it doesn't work.

Just added in https://github.com/emacs-mirror/emacs/commit/dd0dd87e3aaf3116c400fba858cbe35ced15f04e. The implementation looks unnecessarily inefficient though since it always allocates a new symbol. ~~~ elisp (defsubst hash-table-contains-p (key table) "Return non-nil if TABLE has an element...

Is it possible to leverage `eval-when-compile`? ~~~ elisp (defsubst hash-table-contains-p (key table) "Return non-nil if TABLE has an element with KEY." (declare (side-effect-free t) (important-return-value t)) (let ((missing (eval-when-compile (make-symbol...

Reported upstream as https://debbugs.gnu.org/cgi/bugreport.cgi?bug=78162

Done in https://github.com/emacs-compat/compat/commit/cfe89a74a63e8205782b7217ae01145b54a27fcc