Max Friedrich

Results 199 comments of Max Friedrich

The last commit is an experiment for the UX. Instead of standard button presses you can now hold the touch and drag it accross the button matrix. The current button...

Again thank you for the feedback! It means a lot 😊 1. There needs to be an overflow check for the power function. I haven't done this yet. 2. (and...

I did some updates: 1. Power overflow is done. 2. Error messages are done for "too large" and "zero division". 3. The operation label is gone and instead the buttons...

Two UIs seem like one too much for such a restricted device. I agree with the solution, though. Do you think the bpb setting could be made into a slimmer...

Ok, fair points. I almost never use the metronome, so maybe I should not argue too much about its usability. 1. This is the only drop-down in the whole code...

I think you could use the `CheckboxList` class for the settings menu. You can find it in `src/displayapp/screens/CheckboxList.h`.

Oh, ok. Maybe we should rename it to something like `RadioButtonGroup`. Do you think you could still extract an abstract component from your implementation? I could imagine that an actual...

Ok, nice. Thanks for the detailed answer. Given that, I think your PR is fine the way it is now :)

The only name in the code is "Bird", right?

What about those struct types that end with `_t`? Do they fit our code style?