Michal Nazarewicz

Results 56 issues of Michal Nazarewicz

EpochManager::get_validator_info call querying information by block hash turns out to be quite expensive while node is synchronising. My current understanding is that when node is syncing EpochManager does not maintain...

T-node
P-medium

Currently, if serde encounters an unknown field it silently ignores it. We might want to at least warn if this happens. I’ve just spent noticeable amount of time debugging an...

P-low
C-good-first-issue
T-node
Groomed
Node

We have pytest/libs/metrics.py library which is able to operate on one-dimensional metrics. There’s also code to access metrics in pytest/tests/sanity/block_sync_archival.py which could not use metrics module because it needed to...

A-testing
P-low
C-good-first-issue
T-node

Currently in convert_block_to_transactions we’re first sending near_client::GetStateChangesInBlock to get list of all changed accounts and then send near_client::GetStateChanges asking for changes for all those accounts. This can be optimised by...

C-enhancement
P-low
A-RPC
C-good-first-issue
T-node

There is a near_peer_connections_total metric which corresponds to number of PeerActors. This number includes all peers from those we merely sent SYN packet to (so we don’t even know if...

P-low
A-network
T-node
Groomed
Node

The following NayDuck tests are currently broken and disabled: * [x] [https://github.com/near/nearcore/issues/5027](https://github.com/near/nearcore/issues/5027) * [x] `expensive integration-tests client test_gc_after_state_sync` * [x] `expensive integration-tests test_rejoin test::test_4_20_kill2` * [x] `expensive near-client catching_up tests::test_all_chunks_accepted_1000_slow`...

A-testing
A-CI
T-node

Add a `cold_store` Cargo feature which enables the option to configure the node with cold storage. At the moment, all this does is open the cold database and doesn’t enable...

Currently, when RpcRequest::parse handles legacy path+data query format, it first decodes the data and only later checks its size. This means that the server will dutifully decode any oversized buffer...

P-low
S-automerge

Rather than having ShardTries::apply_all create a new StoreUpdate and return it, change it such that it takes the update as an argument. This brings the method in line with other...

P-low
S-automerge

This is a leftover from when the version module was renamed to metadata in commit 8a73b9815: ‘Introduce database kind’.

P-low
S-automerge