Michal Nazarewicz
Michal Nazarewicz
I have the following two bindings: ``` noremap d O noremap D T ``` The idea is to put URL of the current tab on the command prompt but select...
So far we’ve been using ‘col##’ names for the RocksDB column families. This commit proposes to move away from this pattern for new columns and instead use variant name as...
DBCol::variant_name method is redundant considering it can be easily replaced by the features of the Display trait in all places where it is currently used.
Firstly, change is_on_current_chain method to return boolean status rather than error if block is not on current chain. The method is used in two places: in one it’s only used...
Add Temperature enum and NodeStorage struct which introduces a layer between node’s storage and Store interface. As it stand, this is really just complicating code, however, the eventual goal is...
In all call sites of TrieIterator::descend_into_node, the node is fetched just before the descend method call and then it’s never used again. Remove code duplication by pushing fetching of the...
The comment has been added in d11c1cf16a8b1ae00839586db61c1a57df55c3cc and to be honest I don’t quite understand why. What does ‘legacy support’ refer to? That commit added fetch_receipt argument to get_tx_status and...
Recently test_chunk_transaction_validity test started failing for me suggested some nondeterminism. If I run `cargo test` I get a failure: ``` $ cargo test ⋮ thread 'tests::client::process_blocks::access_key_nonce_range_tests::test_chunk_transaction_validity' panicked at 'unexpected errors...
Nodes built with test_features enabled have a `adv_check_store` call which verifies storage. This is used in pytests after each `get_status` call on a node to verify that the storage has...