TDC icon indicating copy to clipboard operation
TDC copied to clipboard

Published 20 hours ago • verified publisher icon mims-harvard

minor fixes for KG scripts

Open abearab opened this issue 9 months ago • 4 comments

  • [x] fill scripts missed from PR #207
  • [x] fix and minor improvements in the KnowledgeGraph and PrimeKGDev classes
  • [ ] write unit tests for primekg api

abearab avatar Apr 29 '24 02:04 abearab

@amva13 This PR is ready for your review, thanks! It mostly contains minor fixes missed in #207

abearab avatar Apr 29 '24 07:04 abearab

Hi @abearab wpuld yoh like to write unit tests for Primekg api? If so and they pass we can approve your changes to main primekg class.

Otherwise, I'll approve primekgdev soon.

A

amva13 avatar May 08 '24 21:05 amva13

Hi @amva13, I'll be happy to write unit tests and replace primekgdev with Primekg api.

abearab avatar May 08 '24 21:05 abearab

Ok great. You can make the changes in this PR and I'll review.

Sent from Proton Mail for iOS

On Wed, May 8, 2024 at 5:44 PM, Abolfazl (Abe) @.***(mailto:On Wed, May 8, 2024 at 5:44 PM, Abolfazl (Abe) < wrote:

Hi @.***(https://github.com/amva13), I'll be happy to write unit tests and replace primekgdev with Primekg api.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

amva13 avatar May 09 '24 01:05 amva13