Michał Woźniak
Michał Woźniak
/lgtm /approve As I synced with @PBundyra there is some missing test coverage, but he will not be able to finish it before vacation. We have ticketed adding the remaining...
/lgtm Just a unit test adjustment for the feature gate.
Actually, MXJob is probably dropped for 0.11 as kubeflow does not support it any longer: https://github.com/kubernetes-sigs/kueue/issues/1429
Found it: https://github.com/kubernetes-sigs/kueue/pull/4077 AFAIK all other integrations should be covered in comments.
> Would you be up for making this integration validation more explicit in the configuration? I'm not sure how this would work TBH, maybe if you provide more details. I...
The validation for the format sounds reasonable. It can provide a quick feedback loop when configuring kueue. However, there are exceptions for the K8s built in types. OTaoH now I...
> The built-ins do not have the optional prefix, but they would still validate correctly as a qualified name Yes, I meant exceptions that don't have the prefix, but you...
By third party you mean an extended Kueue fork or something else? It would be good to be on the same page when designing this. Actually, the last idea is...
This would work, but then one needs to make sure they compile the operator against exactly the same version as used at runtime.
Right, but it still imposes extra work on the admin to make sure the Kueue library version is the same as used at runtime. If they diverge there might be...