David Wong comments

Results 393 comments of


                                            David Wong

Heroku deploy button is busted

This is a problem with the `theme-official` plugin

guppy for diem/diem is ran differently, should we allow peeps to customize how guppy is run for their repo?

the V2 resolver is used for all the builds in docker files (via -Z flag, not via cargo x build) https://github.com/diem/diem/blob/18b6a51aff5f44fca19f0743672e708ace423a7c/docker/build-common.sh#L14 + https://github.com/diem/diem/blob/18b6a51aff/cargo-flags the cargo x build is only used...

repos require `https://` prefixed

So I looked into sanitizing the repo URL earlier, and ended up in a rabbit hole about how git itself validates git repo URLs. It's apparently very lax, and you...

guppy for diem/diem is ran differently, should we allow peeps to customize how guppy is run for their repo?

that's what `cargo x generate-workspace-hack --mode disable` does:

repos require `https://` prefixed

(also, `ssh://` should work as well)