tripeaks-gdx icon indicating copy to clipboard operation
tripeaks-gdx copied to clipboard

Auto dark theme on Android

Open jjrpayne opened this issue 1 year ago • 2 comments

An option to auto-select the dark theme based on the user's system settings would be a nice feature.

jjrpayne avatar Jan 30 '24 00:01 jjrpayne

Hi. I'm not sure if libgdx has an api for querying system theme, but I can add this to my to-do list for my rewrite, that is unfortunately long interrupted due to multiple consecutive health issues. I'll need to redesign the options dialog anyway.

mimoguz avatar Feb 01 '24 05:02 mimoguz

I'd be interested in implementing this if I may contribute. I imagine it should be possible to pass the system theme through the Android launcher if an API query doesn't exist.

jjrpayne avatar Feb 01 '24 06:02 jjrpayne

A draft implementation on the system_theme branch.

mimoguz avatar Aug 19 '24 22:08 mimoguz

Asking for opinions: issue #27

mimoguz avatar Aug 27 '24 16:08 mimoguz

An improvement would be to select the black theme as dark theme, not as an extra option, so the theme would still be dynamic (light/black).

JVariance avatar Aug 29 '24 04:08 JVariance

I don’t know. I don’t want to remove the ‘regular’ dark theme or overcrowd the options dialog. I’ve actually considered adding a fifth option, like 'system with black' or something, but four options already fill the entire height of the dialog 🙂.

mimoguz avatar Aug 29 '24 04:08 mimoguz

Included in the 1.2.0 release.

mimoguz avatar Sep 02 '24 08:09 mimoguz