secp256k1-zkp

secp256k1-zkp copied to clipboard

Code Audit Diffs

1

Upstream is the Elements project code with Bulletproof PR 23 applied: https://github.com/ElementsProject/secp256k1-zkp/pull/23 Downstream is this repository, as of commit 4d64b7b The major differences are: * We've made additions to the...

yeastplume

distcheck build fail

1

One of building job: `BUILD=distcheck` will fail. ``` $ make dist-gzip am__post_remove_distdir='@:' make: *** No rule to make target 'src/bench_aggsig.c', needed by 'distdir'. Stop. ``` Before we find a fix...

garyyu

> Gary Yu @garyyu 14:35 Oh, I can’t find file aggsig/main_impl.h in upstream ElementsProject/secp256k1-zkp#23 ? @yeastplume but the first commit message of this file is updating BPs with master and...

garyyu

aggsig verify: inefficiently allocation every time

1

https://github.com/mimblewimble/secp256k1-zkp/blob/master/src/modules/aggsig/main_impl.h#L498-L499 ``` /* just going to inefficiently allocate every time */ secp256k1_scratch_space *scratch = secp256k1_scratch_space_create(ctx, 1024*4096); ``` Mark here: This line need an optimization, to avoid 4M bytes RAM allocation...

garyyu

Hey, I'm wondering - what is the code that generated the jubjub circuits that are benchmarked? Couldn't find it in the repository. https://github.com/mimblewimble/secp256k1-zkp/blob/c1212d7bd0b0241dc54f9c6675d928d1654074d6/src/bench_bulletproof.c#L15

kobigurk

Is it possible to build this library with MinGW in windows 7? How can I do it?

sergorl