grin-wallet icon indicating copy to clipboard operation
grin-wallet copied to clipboard

Published 20 hours ago • verified publisher icon mimblewimble

Update tokio to v1 and reqwest to v0.11

Open quentinlesceller opened this issue 2 years ago • 2 comments

Based on the build issue we currently have on Windows. This PR update:

  • tokio from 0.2 to 1.29
  • reqwest from 0.10 to 0.11.

~~I'm expecting that some tests might not pass as this is a major upgrade.~~ Locally all tests are passing.

quentinlesceller avatar Jul 25 '23 13:07 quentinlesceller

Yeah, this is likely to be a major upgrade that will need attention to what's changed as well as quite a bit of testing, let's see what errors it comes back with. Note we don't need this right now cause https://github.com/mimblewimble/grin-wallet/pull/685 fixes our current issues, but we likely want to do this soon, perhaps we can do a release soon then look at this right after?

yeastplume avatar Jul 25 '23 13:07 yeastplume

Yes absolutely. And indeed looks like #685 solved the CI issue. Agree to pause this until next release.

quentinlesceller avatar Jul 25 '23 14:07 quentinlesceller