pymilvus icon indicating copy to clipboard operation
pymilvus copied to clipboard

[Bug]: data field type in search function should consider binary data too

Open ventaubain opened this issue 2 years ago • 0 comments

Is there an existing issue for this?

  • [x] I have searched the existing issues

Describe the bug

def search(self,
           data: list[list[float]],
           anns_field: str,
           param: dict,
           limit: int,
           expr: str = None,
           partition_names: list[str] = None,
           output_fields: list[str] = None,
           timeout: float = None,
           round_decimal: int = -1,
           **kwargs: Any) -> SearchResult)

For float_vector search, data: list[list[float]] is ok but if you have a binary_vector, you can have a list[bytes] data format. Currently , the docstring doesn't consider the possibility to have list of bytes and can perturb the user.

Expected Behavior

list[bytes] clearly indicated in the function description

Steps/Code To Reproduce behavior

No response

Environment details

- Hardware/Softward conditions (OS, CPU, GPU, Memory): Ubuntu 22.04
- Method of installation (Docker, or from source): 
- Milvus version (v0.3.1, or v0.4.0): 2.1.3, pymilvus 2.1.3
- Milvus configuration (Settings you made in `server_config.yaml`):

Anything else?

No response

ventaubain avatar Oct 14 '22 09:10 ventaubain