milvus icon indicating copy to clipboard operation
milvus copied to clipboard

fix: [2.6] Sum AllSearchCount from multiple search results

Open junjiejiangjjj opened this issue 1 week ago • 9 comments

https://github.com/milvus-io/milvus/issues/45842 pr: https://github.com/milvus-io/milvus/pull/45914

junjiejiangjjj avatar Nov 27 '25 08:11 junjiejiangjjj

@junjiejiangjjj Please associate the related pr of master to the body of your Pull Request. (eg. "pr: #")

mergify[bot] avatar Nov 27 '25 08:11 mergify[bot]

[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm [master branch only]
  • /ci-rerun-e2e-default // for ci-v2/e2e-default [master branch only]

If you have any questions or requests, please contact @zhikunyao.

sre-ci-robot avatar Nov 27 '25 08:11 sre-ci-robot

[INFO] PR Label Summary by Default [WARNING] No dependent PR reference found

  • Target branch '2.6' requires a PR merged to master first
  • Please add reference in format 'pr: #number'

[WARNING] Milestone not set

  • PR: #45904
  • Title: fix: [2.6] Sum AllSearchCount from multiple search results Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 27 '25 08:11 sre-ci-robot

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 76.60%. Comparing base (cb08db0) to head (58d3fad). :warning: Report is 316 commits behind head on 2.6.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.6   #45904      +/-   ##
==========================================
- Coverage   76.99%   76.60%   -0.39%     
==========================================
  Files        1700     1856     +156     
  Lines      262533   287772   +25239     
==========================================
+ Hits       202142   220459   +18317     
- Misses      53550    59970    +6420     
- Partials     6841     7343     +502     
Components Coverage Δ
Client 78.03% <65.76%> (-0.11%) :arrow_down:
Core 83.66% <79.71%> (+1.45%) :arrow_up:
Go 74.62% <52.20%> (-0.77%) :arrow_down:
Files with missing lines Coverage Δ
internal/proxy/search_pipeline.go 88.11% <100.00%> (-0.84%) :arrow_down:

... and 676 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 27 '25 09:11 codecov[bot]

[INFO] PR Label Summary by Default [FAILED] PR #45914 not merged

  • Title: fix: Sum AllSearchCount from multiple search results
  • Status: OPEN
  • Link: https://github.com/milvus-io/milvus/pull/45914

[WARNING] Milestone not set

  • PR: #45904
  • Title: fix: [2.6] Sum AllSearchCount from multiple search results Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 27 '25 10:11 sre-ci-robot

/ci-rerun-ut

junjiejiangjjj avatar Nov 28 '25 06:11 junjiejiangjjj

[INFO] PR Label Summary by Default [FAILED] PR #45914 not merged

  • Title: fix: Sum AllSearchCount from multiple search results
  • Status: OPEN
  • Link: https://github.com/milvus-io/milvus/pull/45914

[WARNING] Milestone not set

  • PR: #45904
  • Title: fix: [2.6] Sum AllSearchCount from multiple search results Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 28 '25 08:11 sre-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: junjiejiangjjj, liliu-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Nov 28 '25 09:11 sre-ci-robot

[INFO] PR Label Summary by Default [FAILED] PR #45914 not merged

  • Title: fix: Sum AllSearchCount from multiple search results
  • Status: OPEN
  • Link: https://github.com/milvus-io/milvus/pull/45914

[WARNING] Milestone not set

  • PR: #45904
  • Title: fix: [2.6] Sum AllSearchCount from multiple search results Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 28 '25 09:11 sre-ci-robot

/ci-rerun-ut-integration

junjiejiangjjj avatar Dec 01 '25 02:12 junjiejiangjjj

/refresh-label

yanliang567 avatar Dec 01 '25 06:12 yanliang567

[INFO] PR Label Summary by Refresh-Label

  • Title: fix: [2.6] Sum AllSearchCount from multiple search results
  • Target: 2.6
  • Labels: kind/bug, sig/testing, size/L, approved, lgtm, area/test, ci-passed, dco-passed, do-not-merge/need-merge-master-first, do-not-merge/need-milestone

[SUCCESS] PR #45914 merged to master

  • Title: fix: Sum AllSearchCount from multiple search results
  • Link: https://github.com/milvus-io/milvus/pull/45914

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Dec 01 '25 06:12 sre-ci-robot