milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: make estimate json stats size more accurate

Open zhagnlu opened this issue 1 week ago • 6 comments

pr: #45875

zhagnlu avatar Nov 26 '25 12:11 zhagnlu

[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm [master branch only]
  • /ci-rerun-e2e-default // for ci-v2/e2e-default [master branch only]

If you have any questions or requests, please contact @zhikunyao.

sre-ci-robot avatar Nov 26 '25 12:11 sre-ci-robot

[INFO] PR Label Summary by Default [FAILED] PR #45875 not merged

  • Title: enhance: make estimate json stats size more accurate
  • Status: OPEN
  • Link: https://github.com/milvus-io/milvus/pull/45875

[WARNING] Milestone not set

  • PR: #45876
  • Title: enhance: make estimate json stats size more accurate Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 26 '25 12:11 sre-ci-robot

@zhagnlu cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 26 '25 13:11 mergify[bot]

Codecov Report

:x: Patch coverage is 36.36364% with 28 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 76.60%. Comparing base (cb08db0) to head (5a7dc0b). :warning: Report is 319 commits behind head on 2.6.

Files with missing lines Patch % Lines
internal/datanode/index/task_stats.go 0.00% 10 Missing :warning:
internal/querynodev2/segments/segment_loader.go 47.05% 8 Missing and 1 partial :warning:
internal/util/indexcgowrapper/index.go 0.00% 9 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.6   #45876      +/-   ##
==========================================
- Coverage   76.99%   76.60%   -0.40%     
==========================================
  Files        1700     1856     +156     
  Lines      262533   287855   +25322     
==========================================
+ Hits       202142   220502   +18360     
- Misses      53550    60000    +6450     
- Partials     6841     7353     +512     
Components Coverage Δ
Client 78.03% <65.76%> (-0.11%) :arrow_down:
Core 83.66% <79.24%> (+1.45%) :arrow_up:
Go 74.61% <52.20%> (-0.78%) :arrow_down:
Files with missing lines Coverage Δ
pkg/util/paramtable/component_param.go 97.61% <100.00%> (-0.13%) :arrow_down:
internal/querynodev2/segments/segment_loader.go 59.52% <47.05%> (-2.62%) :arrow_down:
internal/util/indexcgowrapper/index.go 56.83% <0.00%> (-0.90%) :arrow_down:
internal/datanode/index/task_stats.go 52.69% <0.00%> (-0.78%) :arrow_down:

... and 655 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 26 '25 14:11 codecov[bot]

[INFO] PR Label Summary by Default [FAILED] PR #45875 not merged

  • Title: enhance: make estimate json stats size more accurate
  • Status: OPEN
  • Link: https://github.com/milvus-io/milvus/pull/45875

[WARNING] Milestone not set

  • PR: #45876
  • Title: enhance: make estimate json stats size more accurate Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 27 '25 03:11 sre-ci-robot

/lgtm

sparknack avatar Dec 01 '25 04:12 sparknack

[INFO] PR Label Summary by Default [FAILED] PR #45875 not merged

  • Title: enhance: make estimate json stats size more accurate
  • Status: OPEN
  • Link: https://github.com/milvus-io/milvus/pull/45875

[WARNING] Milestone not set

  • PR: #45876
  • Title: enhance: make estimate json stats size more accurate Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Dec 01 '25 04:12 sre-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhagnlu, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Dec 01 '25 07:12 sre-ci-robot

[INFO] PR Label Summary by Default [FAILED] PR #45875 not merged

  • Title: enhance: make estimate json stats size more accurate
  • Status: OPEN
  • Link: https://github.com/milvus-io/milvus/pull/45875

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Dec 01 '25 07:12 sre-ci-robot

/refresh-label

zhagnlu avatar Dec 01 '25 07:12 zhagnlu

[INFO] PR Label Summary by Refresh-Label

  • Title: enhance: make estimate json stats size more accurate
  • Target: 2.6
  • Labels: kind/enhancement, size/M, approved, lgtm, ci-passed, dco-passed, do-not-merge/need-merge-master-first

[SUCCESS] PR #45875 merged to master

  • Title: enhance: make estimate json stats size more accurate
  • Link: https://github.com/milvus-io/milvus/pull/45875

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Dec 01 '25 07:12 sre-ci-robot