milvus
milvus copied to clipboard
fix: [2.5] Correcting the incorrect AllSearchCount value in the result of hybrid_search.
Correcting the incorrect AllSearchCount value in the result of hybrid_search. #45842
@lmzzzzz1 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.
@lmzzzzz1 Please associate the related pr of master to the body of your Pull Request. (eg. "pr: #
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm [master branch only]
- /ci-rerun-e2e-default // for ci-v2/e2e-default [master branch only]
If you have any questions or requests, please contact @zhikunyao.
[INFO] PR Label Summary by Default [WARNING] No dependent PR reference found
- Target branch '2.5' requires a PR merged to master first
- Please add reference in format 'pr: #number'
[WARNING] Milestone not set
- PR: #45843
- Title: fix: [2.5] Correcting the incorrect AllSearchCount value in the result of hybrid_search. Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
/assign @liliu-z
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: lmzzzzz1 To complete the pull request process, please ask for approval from liliu-z after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[INFO] PR Label Summary by Default [WARNING] No dependent PR reference found
- Target branch '2.5' requires a PR merged to master first
- Please add reference in format 'pr: #number'
[WARNING] Milestone not set
- PR: #45843
- Title: fix: [2.5] Correcting the incorrect AllSearchCount value in the result of hybrid_search. Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 82.05%. Comparing base (3a7a08f) to head (87aee5f).
:warning: Report is 65 commits behind head on 2.5.
Additional details and impacted files
@@ Coverage Diff @@
## 2.5 #45843 +/- ##
==========================================
- Coverage 82.10% 82.05% -0.05%
==========================================
Files 1128 1587 +459
Lines 179181 248847 +69666
==========================================
+ Hits 147110 204187 +57077
- Misses 26099 38642 +12543
- Partials 5972 6018 +46
| Components | Coverage Δ | |
|---|---|---|
| Client | 78.90% <22.22%> (-0.06%) |
:arrow_down: |
| Core | 84.56% <81.85%> (∅) |
|
| Go | 82.36% <76.78%> (-0.01%) |
:arrow_down: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| internal/proxy/search_reduce_util.go | 85.41% <100.00%> (-1.26%) |
:arrow_down: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@lmzzzzz1 cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
/assign @junjiejiangjjj
/lgtm
[INFO] PR Label Summary by Default [WARNING] No dependent PR reference found
- Target branch '2.5' requires a PR merged to master first
- Please add reference in format 'pr: #number'
[WARNING] Milestone not set
- PR: #45843
- Title: fix: [2.5] Correcting the incorrect AllSearchCount value in the result of hybrid_search. Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
pr: https://github.com/milvus-io/milvus/pull/45914