milvus
milvus copied to clipboard
enhance: support async write syncer for milvus logging
issue: #45640
- log may be dropped if the underlying file system is busy.
- use async write syncer to avoid the log operation block the milvus major system.
- remove some log dependency from the until function to avoid dependency-loop.
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm [master branch only]
- /ci-rerun-e2e-default // for ci-v2/e2e-default [master branch only]
If you have any questions or requests, please contact @zhikunyao.
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 82.73%. Comparing base (b69cd23) to head (52aa065).
:warning: Report is 2 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #45805 +/- ##
=======================================
Coverage 82.73% 82.73%
=======================================
Files 524 524
Lines 82326 82326
=======================================
Hits 68111 68111
Misses 14215 14215
| Components | Coverage Δ | |
|---|---|---|
| Client | ∅ <ø> (∅) |
|
| Core | 82.73% <ø> (ø) |
|
| Go | ∅ <ø> (∅) |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Is there any existed pkg? This feat sounds very common
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: chyezh To complete the pull request process, please ask for approval from liliu-z after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@chyezh cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
/ci-rerun-ut-go
/ci-rerun-ut-integration
/ci-rerun-ut-integration
/ci-rerun-ut-go
/ci-rerun-ut-go
/ci-rerun-ut-integration