milvus
milvus copied to clipboard
fix: use remote wal when local wal shutdown
issue: #45750 pr: #45753
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm [master branch only]
- /ci-rerun-e2e-default // for ci-v2/e2e-default [master branch only]
If you have any questions or requests, please contact @zhikunyao.
[INFO] PR Label Summary by Default [FAILED] PR #45753 not merged
- Title: fix: use remote wal when local wal shutdown
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45753
Use /refresh-label to update related check and label manually
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chyezh, czs007
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~internal/streamingnode/OWNERS~~ [czs007]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[INFO] PR Label Summary by Default [FAILED] PR #45753 not merged
- Title: fix: use remote wal when local wal shutdown
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45753
Use /refresh-label to update related check and label manually
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 76.62%. Comparing base (cb08db0) to head (4ae8160).
:warning: Report is 271 commits behind head on 2.6.
Additional details and impacted files
@@ Coverage Diff @@
## 2.6 #45754 +/- ##
==========================================
- Coverage 76.99% 76.62% -0.38%
==========================================
Files 1700 1856 +156
Lines 262533 287753 +25220
==========================================
+ Hits 202142 220483 +18341
- Misses 53550 59918 +6368
- Partials 6841 7352 +511
| Components | Coverage Δ | |
|---|---|---|
| Client | 78.03% <65.76%> (-0.11%) |
:arrow_down: |
| Core | 83.65% <79.25%> (+1.44%) |
:arrow_up: |
| Go | 74.64% <52.20%> (-0.75%) |
:arrow_down: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| ...treamingnode/client/handler/handler_client_impl.go | 66.34% <100.00%> (-4.21%) |
:arrow_down: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
/ci-rerun-ut-integration
/refresh-label