milvus
milvus copied to clipboard
fix: use remote wal when local wal shutdown
issue: #45750
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm [master branch only]
- /ci-rerun-e2e-default // for ci-v2/e2e-default [master branch only]
If you have any questions or requests, please contact @zhikunyao.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chyezh, czs007
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~internal/streamingnode/OWNERS~~ [czs007]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 76.50%. Comparing base (aa0870d) to head (2819932).
:warning: Report is 19 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #45753 +/- ##
===========================================
- Coverage 83.19% 76.50% -6.70%
===========================================
Files 521 1875 +1354
Lines 81430 292657 +211227
===========================================
+ Hits 67744 223890 +156146
- Misses 13686 61338 +47652
- Partials 0 7429 +7429
| Components | Coverage Δ | |
|---|---|---|
| Client | 78.17% <ø> (∅) |
|
| Core | 83.19% <93.75%> (+<0.01%) |
:arrow_up: |
| Go | 74.61% <71.53%> (∅) |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| ...treamingnode/client/handler/handler_client_impl.go | 66.34% <100.00%> (ø) |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
/ci-rerun-ut-integration
/ci-rerun-ut-integration
/ci-rerun-ut-integration