milvus
milvus copied to clipboard
enhance: add ScalarFieldProto& overload to avoid unnecessary copies
- Array.h: Add output_data(ScalarFieldProto&) overload for both Array and ArrayView classes
- Use std::string_view instead of std::string for VARCHAR and GEOMETRY types to avoid extra string copies
- Call Reserve(length_) before writing to proto objects to reduce memory reallocations
a simple test shows those optimizations improve the Array of Varchar bulk_subscript performance by 20%
issue: https://github.com/milvus-io/milvus/issues/45679
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm [master branch only]
- /ci-rerun-e2e-default // for ci-v2/e2e-default [master branch only]
If you have any questions or requests, please contact @zhikunyao.
@zhengbuqian cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
@zhengbuqian go-sdk check failed, comment rerun go-sdk can trigger the job again.
/ci-rerun-ut
rerun go-sdk
/run-cpu-e2e
@zhengbuqian go-sdk check failed, comment rerun go-sdk can trigger the job again.
@zhengbuqian cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
Codecov Report
:x: Patch coverage is 77.55102% with 11 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 76.48%. Comparing base (8ee8c01) to head (1888370).
:warning: Report is 22 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| internal/core/src/common/Array.h | 80.48% | 8 Missing :warning: |
| internal/core/src/mmap/ChunkedColumnGroup.h | 0.00% | 3 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #45743 +/- ##
==========================================
- Coverage 76.51% 76.48% -0.04%
==========================================
Files 1875 1875
Lines 292559 292602 +43
==========================================
- Hits 223865 223782 -83
- Misses 61271 61389 +118
- Partials 7423 7431 +8
| Components | Coverage Δ | |
|---|---|---|
| Client | 78.17% <ø> (ø) |
|
| Core | 83.20% <77.55%> (+<0.01%) |
:arrow_up: |
| Go | 74.58% <ø> (-0.07%) |
:arrow_down: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| internal/core/src/mmap/ChunkedColumn.h | 74.36% <100.00%> (-0.17%) |
:arrow_down: |
| internal/core/src/mmap/ChunkedColumnInterface.h | 64.70% <ø> (ø) |
|
| ...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp | 64.75% <100.00%> (ø) |
|
| internal/core/src/mmap/ChunkedColumnGroup.h | 44.79% <0.00%> (+0.28%) |
:arrow_up: |
| internal/core/src/common/Array.h | 90.62% <80.48%> (-0.22%) |
:arrow_down: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: liliu-z, zhengbuqian
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~internal/core/OWNERS~~ [liliu-z,zhengbuqian]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment