milvus
milvus copied to clipboard
milvus-io
feat: expose the Go expr parser to C++ and embed into libmilvus-core.so
generated a library that wraps the go expr parser, and embedded that into libmilvus-core.so
issue: https://github.com/milvus-io/milvus/issues/45702
see internal/core/src/plan/milvus_plan_parser.h for the exposed interface
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: zhengbuqian
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [zhengbuqian]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm
If you have any questions or requests, please contact @zhikunyao.
Codecov Report
:x: Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 82.82%. Comparing base (4b14ab1) to head (3ab2b0f).
:warning: Report is 3 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| internal/core/src/plan/milvus_plan_parser.cpp | 0.00% | 35 Missing :warning: |
:x: Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
Additional details and impacted files
@@ Coverage Diff @@
## master #45703 +/- ##
===========================================
+ Coverage 41.20% 82.82% +41.61%
===========================================
Files 1225 525 -700
Lines 194107 82183 -111924
===========================================
- Hits 79982 68064 -11918
+ Misses 113790 14119 -99671
+ Partials 335 0 -335
| Components | Coverage Δ | |
|---|---|---|
| Client | ∅ <ø> (∅) |
|
| Core | 82.82% <0.00%> (-0.04%) |
:arrow_down: |
| Go | ∅ <ø> (∅) |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| internal/core/src/plan/milvus_plan_parser.cpp | 0.00% <0.00%> (ø) |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@zhengbuqian Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.
![mergify[bot] avatar](https://avatars.githubusercontent.com/in/10562?v=4 "Published by a pub.dev verified publisher"){kind=small}
/unhold
it is now embedded into libmilvus-core.so, the user only needs to link this single library and can use the expr parser.
@zhengbuqian cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
@zhengbuqian go-sdk check failed, comment rerun go-sdk can trigger the job again.
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm
If you have any questions or requests, please contact @zhikunyao.
@zhengbuqian go-sdk check failed, comment rerun go-sdk can trigger the job again.
@zhengbuqian cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
@zhengbuqian cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
@zhengbuqian go-sdk check failed, comment rerun go-sdk can trigger the job again.
@zhengbuqian go-sdk check failed, comment rerun go-sdk can trigger the job again.
@zhengbuqian cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
@zhengbuqian cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
@zhengbuqian go-sdk check failed, comment rerun go-sdk can trigger the job again.
@zhengbuqian go-sdk check failed, comment rerun go-sdk can trigger the job again.
@zhengbuqian cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
@zhengbuqian cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
@zhengbuqian go-sdk check failed, comment rerun go-sdk can trigger the job again.