milvus
milvus copied to clipboard
enhance: support text lob
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: zhagnlu
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm
If you have any questions or requests, please contact @zhikunyao.
@zhagnlu Please associate the related issue to the body of your Pull Request. (eg. "issue: #
Codecov Report
:x: Patch coverage is 2.93852% with 2147 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 40.74%. Comparing base (adbdf91) to head (27a6965).
:warning: Report is 33 commits behind head on master.
:x: Your patch check has failed because the patch coverage (2.93%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. :x: Your project check has failed because the head coverage (40.74%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files
@@ Coverage Diff @@
## master #45683 +/- ##
===========================================
- Coverage 73.38% 40.74% -32.64%
===========================================
Files 1365 1239 -126
Lines 212691 196718 -15973
===========================================
- Hits 156073 80155 -75918
- Misses 49181 116226 +67045
+ Partials 7437 337 -7100
| Components | Coverage Δ | |
|---|---|---|
| Client | ∅ <ø> (∅) |
|
| Core | 82.42% <4.96%> (∅) |
|
| Go | 9.41% <2.59%> (-64.63%) |
:arrow_down: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| internal/core/src/segcore/InsertRecord.h | 93.69% <ø> (ø) |
|
| internal/core/src/segcore/SegmentGrowingImpl.h | 63.79% <ø> (ø) |
|
| pkg/metrics/metrics.go | 0.00% <ø> (-33.34%) |
:arrow_down: |
| pkg/util/paramtable/component_param.go | 97.13% <100.00%> (-0.52%) |
:arrow_down: |
| ...ternal/core/src/segcore/ChunkedSegmentSealedImpl.h | 67.50% <0.00%> (ø) |
|
| internal/core/src/common/LoadInfo.h | 50.00% <0.00%> (ø) |
|
| internal/core/src/segcore/GrowingLOBManager.h | 0.00% <0.00%> (ø) |
|
| pkg/util/typeutil/schema.go | 0.66% <0.00%> (-56.26%) |
:arrow_down: |
| pkg/metrics/querynode_metrics.go | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| internal/proxy/task_search.go | 0.00% <0.00%> (-69.37%) |
:arrow_down: |
| ... and 14 more |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm
If you have any questions or requests, please contact @zhikunyao.
@zhagnlu cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
@zhagnlu cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.