milvus icon indicating copy to clipboard operation
milvus copied to clipboard

fix: panic when double close channel of ack broadcast

Open chyezh opened this issue 1 week ago • 10 comments

issue: #45635 pr: #45661

chyezh avatar Nov 18 '25 14:11 chyezh

[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm

If you have any questions or requests, please contact @zhikunyao.

sre-ci-robot avatar Nov 18 '25 14:11 sre-ci-robot

[INFO] PR Label Summary by Default [FAILED] PR #45661 not merged

  • Title: fix: panic when double close channel of ack broadcast
  • Status: OPEN
  • Link: https://github.com/milvus-io/milvus/pull/45661

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 18 '25 14:11 sre-ci-robot

update the mac runner, also see #13046

chyezh avatar Nov 18 '25 14:11 chyezh

@chyezh Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

mergify[bot] avatar Nov 18 '25 14:11 mergify[bot]

[INFO] PR Label Summary by Default [FAILED] PR #45661 not merged

  • Title: fix: panic when double close channel of ack broadcast
  • Status: OPEN
  • Link: https://github.com/milvus-io/milvus/pull/45661

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 18 '25 14:11 sre-ci-robot

[INFO] PR Label Summary by Default [FAILED] PR #45661 not merged

  • Title: fix: panic when double close channel of ack broadcast
  • Status: OPEN
  • Link: https://github.com/milvus-io/milvus/pull/45661

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 18 '25 14:11 sre-ci-robot

[INFO] PR Label Summary by Default [FAILED] PR #45661 not merged

  • Title: fix: panic when double close channel of ack broadcast
  • Status: OPEN
  • Link: https://github.com/milvus-io/milvus/pull/45661

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 18 '25 14:11 sre-ci-robot

/ci-rerun-all

chyezh avatar Nov 18 '25 14:11 chyezh

Codecov Report

:x: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 76.60%. Comparing base (cb08db0) to head (37ea136). :warning: Report is 253 commits behind head on 2.6.

Files with missing lines Patch % Lines
...treamingcoord/server/broadcaster/broadcast_task.go 70.00% 2 Missing and 1 partial :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.6   #45662      +/-   ##
==========================================
- Coverage   76.99%   76.60%   -0.40%     
==========================================
  Files        1700     1856     +156     
  Lines      262533   287667   +25134     
==========================================
+ Hits       202142   220360   +18218     
- Misses      53550    59956    +6406     
- Partials     6841     7351     +510     
Components Coverage Δ
Client 78.03% <65.76%> (-0.11%) :arrow_down:
Core 83.66% <79.17%> (+1.44%) :arrow_up:
Go 74.61% <52.39%> (-0.78%) :arrow_down:
Files with missing lines Coverage Δ
...coord/server/broadcaster/ack_callback_scheduler.go 73.91% <100.00%> (ø)
...amingcoord/server/broadcaster/broadcast_manager.go 71.98% <100.00%> (-5.30%) :arrow_down:
...ingcoord/server/broadcaster/resource_key_locker.go 100.00% <100.00%> (ø)
pkg/util/paramtable/component_param.go 97.61% <100.00%> (-0.14%) :arrow_down:
...treamingcoord/server/broadcaster/broadcast_task.go 78.08% <70.00%> (-8.07%) :arrow_down:

... and 632 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 18 '25 15:11 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Nov 19 '25 02:11 sre-ci-robot

[INFO] PR Label Summary by Default [FAILED] PR #45661 not merged

  • Title: fix: panic when double close channel of ack broadcast
  • Status: OPEN
  • Link: https://github.com/milvus-io/milvus/pull/45661

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 19 '25 02:11 sre-ci-robot

/refresh-label

chyezh avatar Nov 19 '25 06:11 chyezh

/refresh-label

czs007 avatar Nov 19 '25 06:11 czs007

[INFO] PR Label Summary by Default [SUCCESS] PR #45661 merged to master

  • Title: fix: panic when double close channel of ack broadcast
  • Link: https://github.com/milvus-io/milvus/pull/45661

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 19 '25 06:11 sre-ci-robot

[INFO] PR Label Summary by Refresh-Label

  • Title: fix: panic when double close channel of ack broadcast
  • Target: 2.6
  • Labels: kind/bug, size/M, approved, lgtm, dco-passed, do-not-merge/need-merge-master-first

[SUCCESS] PR #45661 merged to master

  • Title: fix: panic when double close channel of ack broadcast
  • Link: https://github.com/milvus-io/milvus/pull/45661

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 19 '25 06:11 sre-ci-robot

[INFO] PR Label Summary by Default [SUCCESS] PR #45661 merged to master

  • Title: fix: panic when double close channel of ack broadcast
  • Link: https://github.com/milvus-io/milvus/pull/45661

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 19 '25 06:11 sre-ci-robot