milvus
milvus copied to clipboard
fix: panic when double close channel of ack broadcast
issue: #45635
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm
If you have any questions or requests, please contact @zhikunyao.
rerun go-sdk
Codecov Report
:x: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 76.49%. Comparing base (947c885) to head (98244af).
:warning: Report is 2 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...treamingcoord/server/broadcaster/broadcast_task.go | 70.00% | 2 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #45661 +/- ##
==========================================
- Coverage 76.51% 76.49% -0.02%
==========================================
Files 1875 1875
Lines 292805 292526 -279
==========================================
- Hits 224039 223769 -270
+ Misses 61337 61329 -8
+ Partials 7429 7428 -1
| Components | Coverage Δ | |
|---|---|---|
| Client | 78.17% <ø> (ø) |
|
| Core | 83.19% <ø> (ø) |
|
| Go | 74.60% <87.50%> (-0.04%) |
:arrow_down: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| ...coord/server/broadcaster/ack_callback_scheduler.go | 73.91% <100.00%> (+1.39%) |
:arrow_up: |
| ...amingcoord/server/broadcaster/broadcast_manager.go | 71.98% <100.00%> (-1.45%) |
:arrow_down: |
| ...ingcoord/server/broadcaster/resource_key_locker.go | 100.00% <100.00%> (ø) |
|
| pkg/util/paramtable/component_param.go | 97.61% <100.00%> (ø) |
|
| ...treamingcoord/server/broadcaster/broadcast_task.go | 78.08% <70.00%> (-0.44%) |
:arrow_down: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
/run-cpu-e2e
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chyezh, czs007
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~internal/streamingcoord/OWNERS~~ [czs007]
- ~~pkg/util/OWNERS~~ [czs007]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.