milvus icon indicating copy to clipboard operation
milvus copied to clipboard

fix: panic when double close channel of broadcaster ack

Open chyezh opened this issue 2 weeks ago • 10 comments

issue: #45635 pr: #45636

chyezh avatar Nov 18 '25 02:11 chyezh

[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm

If you have any questions or requests, please contact @zhikunyao.

sre-ci-robot avatar Nov 18 '25 02:11 sre-ci-robot

[INFO] PR Label Summary by Default [FAILED] PR #45636 not merged

  • Title: fix: panic when double close channel of broadcaster ack
  • Status: OPEN
  • Link: https://github.com/milvus-io/milvus/pull/45636

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 18 '25 02:11 sre-ci-robot

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 83.66%. Comparing base (cb08db0) to head (a780da1). :warning: Report is 250 commits behind head on 2.6.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.6   #45637       +/-   ##
===========================================
+ Coverage   76.99%   83.66%    +6.66%     
===========================================
  Files        1700      513     -1187     
  Lines      262533    78982   -183551     
===========================================
- Hits       202142    66077   -136065     
+ Misses      53550    12905    -40645     
+ Partials     6841        0     -6841     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 83.66% <79.17%> (+1.44%) :arrow_up:
Go ∅ <ø> (∅)
see 1422 files with indirect coverage changes
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 18 '25 03:11 codecov[bot]

/ci-rerun-ut-integration

chyezh avatar Nov 18 '25 05:11 chyezh

[INFO] PR Label Summary by Default [FAILED] PR #45636 not merged

  • Title: fix: panic when double close channel of broadcaster ack
  • Status: OPEN
  • Link: https://github.com/milvus-io/milvus/pull/45636

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 18 '25 06:11 sre-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh To complete the pull request process, please assign liliu-z after the PR has been reviewed. You can assign the PR to them by writing /assign @liliu-z in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Nov 18 '25 06:11 sre-ci-robot

[INFO] PR Label Summary by Default [FAILED] PR #45636 not merged

  • Title: fix: panic when double close channel of broadcaster ack
  • Status: OPEN
  • Link: https://github.com/milvus-io/milvus/pull/45636

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 18 '25 06:11 sre-ci-robot

/ci-rerun-ut-go

chyezh avatar Nov 18 '25 07:11 chyezh

/ci-rerun-ut-integration

chyezh avatar Nov 18 '25 08:11 chyezh

[INFO] PR Label Summary by Default [FAILED] PR #45636 not merged

  • Title: fix: panic when double close channel of broadcaster ack
  • Status: OPEN
  • Link: https://github.com/milvus-io/milvus/pull/45636

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 18 '25 11:11 sre-ci-robot

/ci-rerun-ut-integration

chyezh avatar Nov 18 '25 14:11 chyezh

/ci-rerun-ut-go

chyezh avatar Nov 18 '25 14:11 chyezh

/ci-rerun-ut-go

chyezh avatar Nov 18 '25 14:11 chyezh

/ci-rerun-ut-integration

chyezh avatar Nov 18 '25 14:11 chyezh

/ci-rerun-ut-go

chyezh avatar Nov 18 '25 14:11 chyezh

@chyezh Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

mergify[bot] avatar Nov 18 '25 14:11 mergify[bot]