milvus icon indicating copy to clipboard operation
milvus copied to clipboard

fix: correct default value backfill during AddField

Open czs007 opened this issue 2 weeks ago • 5 comments

issue: https://github.com/milvus-io/milvus/issues/44585

czs007 avatar Nov 18 '25 00:11 czs007

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Nov 18 '25 00:11 sre-ci-robot

[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm

If you have any questions or requests, please contact @zhikunyao.

sre-ci-robot avatar Nov 18 '25 00:11 sre-ci-robot

Codecov Report

:x: Patch coverage is 11.73913% with 203 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 76.49%. Comparing base (caed0fe) to head (44a1bb2). :warning: Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
pkg/util/timestamptz/timestamptz.go 13.08% 164 Missing and 2 partials :warning:
...tcoord/ddl_callbacks_alter_collection_add_field.go 0.00% 5 Missing and 1 partial :warning:
internal/proxy/http_req_impl.go 0.00% 4 Missing and 1 partial :warning:
internal/proxy/service_provider.go 20.00% 3 Missing and 1 partial :warning:
internal/proxy/validate_util.go 0.00% 3 Missing :warning:
internal/parser/planparserv2/parser_visitor.go 0.00% 2 Missing :warning:
internal/proxy/task.go 0.00% 0 Missing and 2 partials :warning:
internal/proxy/task_database.go 0.00% 0 Missing and 2 partials :warning:
internal/rootcoord/create_collection_task.go 0.00% 0 Missing and 2 partials :warning:
internal/util/importutilv2/parquet/field_reader.go 0.00% 2 Missing :warning:
... and 9 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #45634       +/-   ##
===========================================
- Coverage   83.18%   76.49%    -6.70%     
===========================================
  Files         521     1875     +1354     
  Lines       81313   292103   +210790     
===========================================
+ Hits        67642   223444   +155802     
- Misses      13671    61252    +47581     
- Partials        0     7407     +7407     
Components Coverage Δ
Client 78.17% <ø> (∅)
Core 83.18% <ø> (ø)
Go 74.60% <11.73%> (∅)
Files with missing lines Coverage Δ
internal/proxy/impl.go 72.69% <ø> (ø)
...ernal/rootcoord/ddl_callbacks_create_collection.go 85.81% <100.00%> (ø)
internal/rootcoord/describe_collection_task.go 91.89% <ø> (ø)
internal/rootcoord/root_coord.go 78.88% <ø> (ø)
internal/proxy/task_query.go 74.49% <0.00%> (ø)
internal/proxy/task_search.go 68.98% <0.00%> (ø)
internal/proxy/util.go 80.87% <0.00%> (ø)
...coord/ddl_callbacks_alter_collection_properties.go 79.48% <0.00%> (ø)
internal/rootcoord/ddl_callbacks_alter_database.go 71.77% <0.00%> (ø)
...nternal/rootcoord/ddl_callbacks_create_database.go 61.70% <0.00%> (ø)
... and 13 more

... and 1331 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 18 '25 01:11 codecov[bot]

@czs007 cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 18 '25 01:11 mergify[bot]

/ci-rerun-ut-integration

czs007 avatar Nov 18 '25 08:11 czs007

the conclusion offline is to address issues in next pr /lgtm

congqixia avatar Nov 18 '25 15:11 congqixia