milvus
milvus copied to clipboard
fix: compact the assignment history of channel to decrease the size of assignment recovery info
issue: #45210
If the underlying WAL is failed to open, the recovery info size of streaming coord streamingcoord-meta/pchannel will increase fast until reaching the etcd limitation.
So make a compaction by serverID at assignment history to decrease the streamingcoord-meta/pchannel size.
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm
If you have any questions or requests, please contact @zhikunyao.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chyezh, czs007
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~internal/streamingcoord/OWNERS~~ [czs007]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 76.47%. Comparing base (96d0e78) to head (610adbf).
:warning: Report is 5 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #45606 +/- ##
==========================================
- Coverage 76.55% 76.47% -0.09%
==========================================
Files 1875 1875
Lines 291983 291999 +16
==========================================
- Hits 223531 223305 -226
- Misses 61073 61277 +204
- Partials 7379 7417 +38
| Components | Coverage Δ | |
|---|---|---|
| Client | 78.17% <ø> (ø) |
|
| Core | 83.18% <ø> (ø) |
|
| Go | 74.57% <100.00%> (-0.12%) |
:arrow_down: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| ...streamingcoord/server/balancer/channel/pchannel.go | 100.00% <100.00%> (ø) |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@chyezh cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
@chyezh cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
@chyezh cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e