milvus icon indicating copy to clipboard operation
milvus copied to clipboard

feat: support struct array for restful(#45496)

Open MrPresent-Han opened this issue 3 weeks ago • 4 comments

related: #45496

MrPresent-Han avatar Nov 14 '25 06:11 MrPresent-Han

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MrPresent-Han To complete the pull request process, please assign yanliang567 after the PR has been reviewed. You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Nov 14 '25 06:11 sre-ci-robot

[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm

If you have any questions or requests, please contact @zhikunyao.

sre-ci-robot avatar Nov 14 '25 06:11 sre-ci-robot

Codecov Report

:x: Patch coverage is 0% with 436 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 41.31%. Comparing base (0a208d7) to head (bcbbf99). :warning: Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
internal/distributed/proxy/httpserver/utils.go 0.00% 192 Missing :warning:
...ernal/distributed/proxy/httpserver/struct_utils.go 0.00% 167 Missing :warning:
...nternal/distributed/proxy/httpserver/handler_v2.go 0.00% 57 Missing :warning:
pkg/util/typeutil/convension.go 0.00% 19 Missing :warning:
...nternal/distributed/proxy/httpserver/request_v2.go 0.00% 1 Missing :warning:

:x: Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. :x: Your project check has failed because the head coverage (41.31%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #45571      +/-   ##
==========================================
- Coverage   41.40%   41.31%   -0.10%     
==========================================
  Files        1218     1219       +1     
  Lines      192156   192567     +411     
==========================================
- Hits        79561    79554       -7     
- Misses     112260   112678     +418     
  Partials      335      335              
Components Coverage Δ
Client ∅ <ø> (∅)
Core 83.18% <ø> (ø)
Go 9.52% <0.00%> (-0.05%) :arrow_down:
Files with missing lines Coverage Δ
...nternal/distributed/proxy/httpserver/request_v2.go 0.00% <0.00%> (ø)
pkg/util/typeutil/convension.go 0.00% <0.00%> (ø)
...nternal/distributed/proxy/httpserver/handler_v2.go 0.00% <0.00%> (ø)
...ernal/distributed/proxy/httpserver/struct_utils.go 0.00% <0.00%> (ø)
internal/distributed/proxy/httpserver/utils.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 14 '25 08:11 codecov[bot]

@MrPresent-Han cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 14 '25 10:11 mergify[bot]

[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm

If you have any questions or requests, please contact @zhikunyao.

sre-ci-robot avatar Nov 20 '25 05:11 sre-ci-robot