milvus
milvus copied to clipboard
feat:[2.6]Support function add/drop/alter
pr: https://github.com/milvus-io/milvus/pull/44895 https://github.com/milvus-io/milvus/issues/44053
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: junjiejiangjjj
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm
If you have any questions or requests, please contact @zhikunyao.
@junjiejiangjjj Please associate the related issue to the body of your Pull Request. (eg. "issue: #
[INFO] PR Label Summary by Default [SUCCESS] PR #44895 merged to master
- Title: feat: Support add_function/alter_function/drop_function
- Link: https://github.com/milvus-io/milvus/pull/44895
[WARNING] Milestone not set
- PR: #45570
- Title: feat:[2.6]Support function add/drop/alter Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
Codecov Report
:x: Patch coverage is 75.23057% with 188 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 76.52%. Comparing base (7b6aa21) to head (342a237).
:warning: Report is 3 commits behind head on 2.6.
Additional details and impacted files
@@ Coverage Diff @@
## 2.6 #45570 +/- ##
==========================================
+ Coverage 73.87% 76.52% +2.64%
==========================================
Files 1348 1863 +515
Lines 208943 289162 +80219
==========================================
+ Hits 154367 221287 +66920
- Misses 47259 60497 +13238
- Partials 7317 7378 +61
| Components | Coverage Δ | |
|---|---|---|
| Client | 78.03% <ø> (ø) |
|
| Core | 83.55% <ø> (∅) |
|
| Go | 74.56% <75.23%> (-0.03%) |
:arrow_down: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| internal/distributed/mixcoord/client/client.go | 87.05% <100.00%> (+0.26%) |
:arrow_up: |
| internal/proxy/task.go | 78.04% <ø> (-0.16%) |
:arrow_down: |
| ...util/function/embedding/text_embedding_function.go | 89.40% <ø> (ø) |
|
| internal/util/mock/grpc_rootcoord_client.go | 84.17% <100.00%> (+0.71%) |
:arrow_up: |
| internal/metastore/kv/rootcoord/kv_catalog.go | 76.30% <62.50%> (-0.09%) |
:arrow_down: |
| internal/coordinator/mix_coord.go | 67.84% <0.00%> (-0.56%) |
:arrow_down: |
| internal/distributed/mixcoord/service.go | 79.44% <0.00%> (-1.03%) |
:arrow_down: |
| internal/distributed/proxy/service.go | 76.97% <0.00%> (-0.66%) |
:arrow_down: |
| ...nternal/distributed/proxy/httpserver/handler_v2.go | 86.42% <80.95%> (-0.14%) |
:arrow_down: |
| ...nternal/distributed/proxy/httpserver/request_v2.go | 76.21% <17.64%> (-5.27%) |
:arrow_down: |
| ... and 4 more |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
[INFO] PR Label Summary by Default [SUCCESS] PR #44895 merged to master
- Title: feat: Support add_function/alter_function/drop_function
- Link: https://github.com/milvus-io/milvus/pull/44895
[WARNING] Milestone not set
- PR: #45570
- Title: feat:[2.6]Support function add/drop/alter Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
[INFO] PR Label Summary by Default [SUCCESS] PR #44895 merged to master
- Title: feat: Support add_function/alter_function/drop_function
- Link: https://github.com/milvus-io/milvus/pull/44895
[WARNING] Milestone not set
- PR: #45570
- Title: feat:[2.6]Support function add/drop/alter Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
@junjiejiangjjj cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm
If you have any questions or requests, please contact @zhikunyao.
[INFO] PR Label Summary by Default [SUCCESS] PR #44895 merged to master
- Title: feat: Support add_function/alter_function/drop_function
- Link: https://github.com/milvus-io/milvus/pull/44895
[WARNING] Milestone not set
- PR: #45570
- Title: feat:[2.6]Support function add/drop/alter Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
@junjiejiangjjj go-sdk check failed, comment rerun go-sdk can trigger the job again.
[INFO] PR Label Summary by Default [SUCCESS] PR #44895 merged to master
- Title: feat: Support add_function/alter_function/drop_function
- Link: https://github.com/milvus-io/milvus/pull/44895
[WARNING] Milestone not set
- PR: #45570
- Title: feat:[2.6]Support function add/drop/alter Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
@junjiejiangjjj go-sdk check failed, comment rerun go-sdk can trigger the job again.
rerun go-sdk
@junjiejiangjjj go-sdk check failed, comment rerun go-sdk can trigger the job again.
@junjiejiangjjj cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
[INFO] PR Label Summary by Default [SUCCESS] PR #44895 merged to master
- Title: feat: Support add_function/alter_function/drop_function
- Link: https://github.com/milvus-io/milvus/pull/44895
[WARNING] Milestone not set
- PR: #45570
- Title: feat:[2.6]Support function add/drop/alter Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
@junjiejiangjjj cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
[INFO] PR Label Summary by Default [SUCCESS] PR #44895 merged to master
- Title: feat: Support add_function/alter_function/drop_function
- Link: https://github.com/milvus-io/milvus/pull/44895
[WARNING] Milestone not set
- PR: #45570
- Title: feat:[2.6]Support function add/drop/alter Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
[INFO] PR Label Summary by Default [SUCCESS] PR #44895 merged to master
- Title: feat: Support add_function/alter_function/drop_function
- Link: https://github.com/milvus-io/milvus/pull/44895
[WARNING] Milestone not set
- PR: #45570
- Title: feat:[2.6]Support function add/drop/alter Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
/ci-rerun-ut-integration