milvus icon indicating copy to clipboard operation
milvus copied to clipboard

feat:[2.6]Support function add/drop/alter

Open junjiejiangjjj opened this issue 3 weeks ago • 22 comments

pr: https://github.com/milvus-io/milvus/pull/44895 https://github.com/milvus-io/milvus/issues/44053

junjiejiangjjj avatar Nov 14 '25 06:11 junjiejiangjjj

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: junjiejiangjjj To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed. You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Nov 14 '25 06:11 sre-ci-robot

[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm

If you have any questions or requests, please contact @zhikunyao.

sre-ci-robot avatar Nov 14 '25 06:11 sre-ci-robot

@junjiejiangjjj Please associate the related issue to the body of your Pull Request. (eg. "issue: #")

mergify[bot] avatar Nov 14 '25 06:11 mergify[bot]

[INFO] PR Label Summary by Default [SUCCESS] PR #44895 merged to master

  • Title: feat: Support add_function/alter_function/drop_function
  • Link: https://github.com/milvus-io/milvus/pull/44895

[WARNING] Milestone not set

  • PR: #45570
  • Title: feat:[2.6]Support function add/drop/alter Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 14 '25 06:11 sre-ci-robot

Codecov Report

:x: Patch coverage is 75.23057% with 188 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 76.52%. Comparing base (7b6aa21) to head (342a237). :warning: Report is 3 commits behind head on 2.6.

Files with missing lines Patch % Lines
internal/proxy/impl.go 63.51% 45 Missing and 9 partials :warning:
...nal/rootcoord/ddl_callbacks_collection_function.go 76.81% 36 Missing and 12 partials :warning:
internal/proxy/function_task.go 87.09% 18 Missing and 6 partials :warning:
internal/rootcoord/root_coord.go 81.01% 12 Missing and 3 partials :warning:
...nternal/distributed/proxy/httpserver/request_v2.go 17.64% 14 Missing :warning:
...nternal/distributed/proxy/httpserver/handler_v2.go 80.95% 10 Missing and 2 partials :warning:
internal/coordinator/mix_coord.go 0.00% 6 Missing :warning:
internal/distributed/mixcoord/service.go 0.00% 6 Missing :warning:
internal/distributed/proxy/service.go 0.00% 6 Missing :warning:
internal/metastore/kv/rootcoord/kv_catalog.go 62.50% 2 Missing and 1 partial :warning:
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.6   #45570      +/-   ##
==========================================
+ Coverage   73.87%   76.52%   +2.64%     
==========================================
  Files        1348     1863     +515     
  Lines      208943   289162   +80219     
==========================================
+ Hits       154367   221287   +66920     
- Misses      47259    60497   +13238     
- Partials     7317     7378      +61     
Components Coverage Δ
Client 78.03% <ø> (ø)
Core 83.55% <ø> (∅)
Go 74.56% <75.23%> (-0.03%) :arrow_down:
Files with missing lines Coverage Δ
internal/distributed/mixcoord/client/client.go 87.05% <100.00%> (+0.26%) :arrow_up:
internal/proxy/task.go 78.04% <ø> (-0.16%) :arrow_down:
...util/function/embedding/text_embedding_function.go 89.40% <ø> (ø)
internal/util/mock/grpc_rootcoord_client.go 84.17% <100.00%> (+0.71%) :arrow_up:
internal/metastore/kv/rootcoord/kv_catalog.go 76.30% <62.50%> (-0.09%) :arrow_down:
internal/coordinator/mix_coord.go 67.84% <0.00%> (-0.56%) :arrow_down:
internal/distributed/mixcoord/service.go 79.44% <0.00%> (-1.03%) :arrow_down:
internal/distributed/proxy/service.go 76.97% <0.00%> (-0.66%) :arrow_down:
...nternal/distributed/proxy/httpserver/handler_v2.go 86.42% <80.95%> (-0.14%) :arrow_down:
...nternal/distributed/proxy/httpserver/request_v2.go 76.21% <17.64%> (-5.27%) :arrow_down:
... and 4 more

... and 555 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 14 '25 08:11 codecov[bot]

[INFO] PR Label Summary by Default [SUCCESS] PR #44895 merged to master

  • Title: feat: Support add_function/alter_function/drop_function
  • Link: https://github.com/milvus-io/milvus/pull/44895

[WARNING] Milestone not set

  • PR: #45570
  • Title: feat:[2.6]Support function add/drop/alter Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 18 '25 02:11 sre-ci-robot

[INFO] PR Label Summary by Default [SUCCESS] PR #44895 merged to master

  • Title: feat: Support add_function/alter_function/drop_function
  • Link: https://github.com/milvus-io/milvus/pull/44895

[WARNING] Milestone not set

  • PR: #45570
  • Title: feat:[2.6]Support function add/drop/alter Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 18 '25 06:11 sre-ci-robot

@junjiejiangjjj cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 18 '25 09:11 mergify[bot]

/run-cpu-e2e

junjiejiangjjj avatar Nov 18 '25 09:11 junjiejiangjjj

[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm

If you have any questions or requests, please contact @zhikunyao.

sre-ci-robot avatar Nov 20 '25 05:11 sre-ci-robot

[INFO] PR Label Summary by Default [SUCCESS] PR #44895 merged to master

  • Title: feat: Support add_function/alter_function/drop_function
  • Link: https://github.com/milvus-io/milvus/pull/44895

[WARNING] Milestone not set

  • PR: #45570
  • Title: feat:[2.6]Support function add/drop/alter Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 21 '25 02:11 sre-ci-robot

@junjiejiangjjj go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Nov 21 '25 03:11 mergify[bot]

[INFO] PR Label Summary by Default [SUCCESS] PR #44895 merged to master

  • Title: feat: Support add_function/alter_function/drop_function
  • Link: https://github.com/milvus-io/milvus/pull/44895

[WARNING] Milestone not set

  • PR: #45570
  • Title: feat:[2.6]Support function add/drop/alter Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 24 '25 06:11 sre-ci-robot

@junjiejiangjjj go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Nov 24 '25 06:11 mergify[bot]

rerun go-sdk

junjiejiangjjj avatar Nov 24 '25 06:11 junjiejiangjjj

@junjiejiangjjj go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Nov 24 '25 07:11 mergify[bot]

@junjiejiangjjj cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 24 '25 07:11 mergify[bot]

[INFO] PR Label Summary by Default [SUCCESS] PR #44895 merged to master

  • Title: feat: Support add_function/alter_function/drop_function
  • Link: https://github.com/milvus-io/milvus/pull/44895

[WARNING] Milestone not set

  • PR: #45570
  • Title: feat:[2.6]Support function add/drop/alter Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 24 '25 08:11 sre-ci-robot

@junjiejiangjjj cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 24 '25 10:11 mergify[bot]

[INFO] PR Label Summary by Default [SUCCESS] PR #44895 merged to master

  • Title: feat: Support add_function/alter_function/drop_function
  • Link: https://github.com/milvus-io/milvus/pull/44895

[WARNING] Milestone not set

  • PR: #45570
  • Title: feat:[2.6]Support function add/drop/alter Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Nov 24 '25 10:11 sre-ci-robot

[INFO] PR Label Summary by Default [SUCCESS] PR #44895 merged to master

  • Title: feat: Support add_function/alter_function/drop_function
  • Link: https://github.com/milvus-io/milvus/pull/44895

[WARNING] Milestone not set

  • PR: #45570
  • Title: feat:[2.6]Support function add/drop/alter Please set a milestone for better release tracking

You can set milestone by commenting: /set-milestone Example: /set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sre-ci-robot avatar Dec 03 '25 02:12 sre-ci-robot

/ci-rerun-ut-integration

junjiejiangjjj avatar Dec 03 '25 06:12 junjiejiangjjj