milvus
milvus copied to clipboard
enhance: add more metrics for DDL framework
issue: #43897 pr: #45558
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm
If you have any questions or requests, please contact @zhikunyao.
[INFO] PR Label Summary by Default [FAILED] PR #45558 not merged
- Title: enhance: add more metrics for DDL framework
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45558
[WARNING] Milestone not set
- PR: #45559
- Title: enhance: add more metrics for DDL framework Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
Codecov Report
:x: Patch coverage is 93.44262% with 4 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 76.63%. Comparing base (df05e7c) to head (eb0bd3a).
:warning: Report is 5 commits behind head on 2.6.
Additional details and impacted files
@@ Coverage Diff @@
## 2.6 #45559 +/- ##
==========================================
+ Coverage 76.61% 76.63% +0.02%
==========================================
Files 1856 1856
Lines 287539 287565 +26
==========================================
+ Hits 220287 220369 +82
+ Misses 59913 59863 -50
+ Partials 7339 7333 -6
| Components | Coverage Δ | |
|---|---|---|
| Client | 78.03% <ø> (ø) |
|
| Core | 83.66% <ø> (ø) |
|
| Go | 74.65% <93.44%> (+0.03%) |
:arrow_up: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| ...coord/server/broadcaster/ack_callback_scheduler.go | 72.51% <100.00%> (+0.64%) |
:arrow_up: |
| ...ernal/streamingcoord/server/broadcaster/metrics.go | 100.00% <100.00%> (+11.11%) |
:arrow_up: |
| pkg/metrics/streaming_service_metrics.go | 100.00% <100.00%> (ø) |
|
| pkg/streaming/util/message/resource_key.go | 90.32% <100.00%> (+0.66%) |
:arrow_up: |
| ...treamingcoord/server/broadcaster/broadcast_task.go | 78.52% <90.00%> (-0.16%) |
:arrow_down: |
| ...amingcoord/server/broadcaster/broadcast_manager.go | 71.98% <50.00%> (-0.80%) |
:arrow_down: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
/refresh-label
/ci-rerun-code-check
[INFO] PR Label Summary by Refresh-Label
- Title: enhance: add more metrics for DDL framework
- Target: 2.6
- Labels: kind/enhancement, size/L, dco-passed, do-not-merge/need-merge-master-first, do-not-merge/need-milestone
[FAILED] PR #45558 not merged
- Title: enhance: add more metrics for DDL framework
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45558
Use /refresh-label to update related check and label manually
[INFO] PR Label Summary by Default [FAILED] PR #45558 not merged
- Title: enhance: add more metrics for DDL framework
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45558
Use /refresh-label to update related check and label manually
@chyezh cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
/ci-rerun-ut-cpp
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chyezh, czs007
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [czs007]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[INFO] PR Label Summary by Default [FAILED] PR #45558 not merged
- Title: enhance: add more metrics for DDL framework
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45558
Use /refresh-label to update related check and label manually
/refresh-label
[INFO] PR Label Summary by Refresh-Label
- Title: enhance: add more metrics for DDL framework
- Target: 2.6
- Labels: kind/enhancement, size/L, approved, lgtm, ci-passed, dco-passed, do-not-merge/need-merge-master-first
[SUCCESS] PR #45558 merged to master
- Title: enhance: add more metrics for DDL framework
- Link: https://github.com/milvus-io/milvus/pull/45558
Use /refresh-label to update related check and label manually