milvus icon indicating copy to clipboard operation
milvus copied to clipboard

enhance: add more metrics for DDL framework

Open chyezh opened this issue 2 weeks ago • 2 comments

issue: #43897

chyezh avatar Nov 13 '25 13:11 chyezh

[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm

If you have any questions or requests, please contact @zhikunyao.

sre-ci-robot avatar Nov 13 '25 13:11 sre-ci-robot

Codecov Report

:x: Patch coverage is 93.44262% with 4 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 76.55%. Comparing base (a9895bb) to head (8a01f83). :warning: Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
...amingcoord/server/broadcaster/broadcast_manager.go 50.00% 2 Missing and 1 partial :warning:
...treamingcoord/server/broadcaster/broadcast_task.go 90.00% 1 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #45558       +/-   ##
===========================================
- Coverage   83.37%   76.55%    -6.82%     
===========================================
  Files         521     1875     +1354     
  Lines       81105   291806   +210701     
===========================================
+ Hits        67619   223397   +155778     
- Misses      13486    60993    +47507     
- Partials        0     7416     +7416     
Components Coverage Δ
Client 78.17% <ø> (∅)
Core 83.35% <60.97%> (-0.02%) :arrow_down:
Go 74.63% <73.31%> (∅)
Files with missing lines Coverage Δ
...coord/server/broadcaster/ack_callback_scheduler.go 72.51% <100.00%> (ø)
...ernal/streamingcoord/server/broadcaster/metrics.go 100.00% <100.00%> (ø)
pkg/metrics/streaming_service_metrics.go 100.00% <100.00%> (ø)
pkg/streaming/util/message/resource_key.go 90.32% <100.00%> (ø)
...treamingcoord/server/broadcaster/broadcast_task.go 78.52% <90.00%> (ø)
...amingcoord/server/broadcaster/broadcast_manager.go 71.98% <50.00%> (ø)

... and 1343 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 13 '25 15:11 codecov[bot]

/ci-rerun-code-check

chyezh avatar Nov 13 '25 15:11 chyezh

/ci-rerun-ut-integration

chyezh avatar Nov 13 '25 15:11 chyezh

/ci-rerun-ut-go

chyezh avatar Nov 14 '25 03:11 chyezh

/ci-rerun-ut-integration

chyezh avatar Nov 14 '25 05:11 chyezh

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Nov 14 '25 07:11 sre-ci-robot