milvus
milvus copied to clipboard
enhance: expr: [2.6] only prefetch chunks once
issue: https://github.com/milvus-io/milvus/issues/43611 pr: #45554
@sparknack Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm
If you have any questions or requests, please contact @zhikunyao.
/refresh-labels
/refresh-label
@sparknack go-sdk check failed, comment rerun go-sdk can trigger the job again.
[INFO] PR Label Summary by Refresh-Label
- Title: enhance: expr: [2.6] only prefetch chunks once
- Target: 2.6
- Labels: kind/enhancement, area/dependency, sig/testing, size/L, area/test, area/internal-api, needs-dco, area/compilation, test/integration
[FAILED] PR #45554 not merged
- Title: enhance: expr: only prefetch chunks once
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45554
[WARNING] Milestone not set
- PR: #45555
- Title: enhance: expr: [2.6] only prefetch chunks once Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
[INFO] PR Label Summary by Default [FAILED] PR #45554 not merged
- Title: enhance: expr: only prefetch chunks once
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45554
[WARNING] Milestone not set
- PR: #45555
- Title: enhance: expr: [2.6] only prefetch chunks once Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
@sparknack go-sdk check failed, comment rerun go-sdk can trigger the job again.
[INFO] PR Label Summary by Default [FAILED] PR #45554 not merged
- Title: enhance: expr: only prefetch chunks once
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45554
[WARNING] Milestone not set
- PR: #45555
- Title: enhance: expr: [2.6] only prefetch chunks once Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 76.60%. Comparing base (df05e7c) to head (fa66b66).
:warning: Report is 8 commits behind head on 2.6.
:x: Your project status has failed because the head coverage (76.60%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files
@@ Coverage Diff @@
## 2.6 #45555 +/- ##
==========================================
- Coverage 76.61% 76.60% -0.02%
==========================================
Files 1856 1856
Lines 287539 287540 +1
==========================================
- Hits 220287 220258 -29
- Misses 59913 59943 +30
Partials 7339 7339
| Components | Coverage Δ | |
|---|---|---|
| Client | 78.03% <ø> (ø) |
|
| Core | 83.66% <100.00%> (+<0.01%) |
:arrow_up: |
| Go | 74.61% <ø> (-0.02%) |
:arrow_down: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| internal/core/src/exec/expression/Expr.h | 69.03% <100.00%> (+0.11%) |
:arrow_up: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
/set-milestone 2.6.6
/ci-rerun-ut-integration
[ERROR] Failed to set milestone: 2.6.6
/lgtm
[INFO] PR Label Summary by Default [FAILED] PR #45554 not merged
- Title: enhance: expr: only prefetch chunks once
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45554
[WARNING] Milestone not set
- PR: #45555
- Title: enhance: expr: [2.6] only prefetch chunks once Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: sparknack, zhengbuqian
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~internal/core/OWNERS~~ [zhengbuqian]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[INFO] PR Label Summary by Default [FAILED] PR #45554 not merged
- Title: enhance: expr: only prefetch chunks once
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45554
[WARNING] Milestone not set
- PR: #45555
- Title: enhance: expr: [2.6] only prefetch chunks once Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually