milvus
milvus copied to clipboard
enhance: [2.6] Subdivide the CPU slot and memory slot of the tasks
issue: https://github.com/milvus-io/milvus/issues/45186 master pr: https://github.com/milvus-io/milvus/pull/45226
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: xiaocai2333
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[INFO] PR Label Summary by Default [FAILED] PR #45226 not merged
- Title: enhance: Subdivide the CPU slot and memory slot of the tasks
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45226
[WARNING] Milestone not set
- PR: #45537
- Title: enhance: [2.6] Subdivide the CPU slot and memory slot of the tasks Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm
If you have any questions or requests, please contact @zhikunyao.
@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.
Codecov Report
:x: Patch coverage is 97.33333% with 2 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 41.27%. Comparing base (cb08db0) to head (7e73b72).
:warning: Report is 259 commits behind head on 2.6.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| pkg/metrics/datanode_metrics.go | 0.00% | 2 Missing :warning: |
:x: Your project check has failed because the head coverage (41.27%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files
@@ Coverage Diff @@
## 2.6 #45537 +/- ##
===========================================
- Coverage 76.99% 41.27% -35.73%
===========================================
Files 1700 1207 -493
Lines 262533 189030 -73503
===========================================
- Hits 202142 78024 -124118
- Misses 53550 110674 +57124
+ Partials 6841 332 -6509
| Components | Coverage Δ | |
|---|---|---|
| Client | ∅ <ø> (∅) |
|
| Core | 83.65% <79.04%> (+1.43%) |
:arrow_up: |
| Go | 9.64% <5.00%> (-65.75%) |
:arrow_down: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| pkg/metrics/metrics.go | 0.00% <ø> (-33.34%) |
:arrow_down: |
| pkg/util/paramtable/component_param.go | 97.10% <100.00%> (-0.65%) |
:arrow_down: |
| pkg/metrics/datanode_metrics.go | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
[INFO] PR Label Summary by Default [FAILED] PR #45226 not merged
- Title: enhance: Subdivide the CPU slot and memory slot of the tasks
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45226
Use /refresh-label to update related check and label manually
@xiaocai2333 cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
[INFO] PR Label Summary by Default [FAILED] PR #45226 not merged
- Title: enhance: Subdivide the CPU slot and memory slot of the tasks
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45226
Use /refresh-label to update related check and label manually
@xiaocai2333 cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
[INFO] PR Label Summary by Default [FAILED] PR #45226 not merged
- Title: enhance: Subdivide the CPU slot and memory slot of the tasks
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45226
Use /refresh-label to update related check and label manually
[INFO] PR Label Summary by Default [FAILED] PR #45226 not merged
- Title: enhance: Subdivide the CPU slot and memory slot of the tasks
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45226
Use /refresh-label to update related check and label manually
@xiaocai2333 cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm
If you have any questions or requests, please contact @zhikunyao.