milvus
milvus copied to clipboard
fix: Ignore compaction task when from segment is not healthy
issue: #45533
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm
If you have any questions or requests, please contact @zhikunyao.
@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.
Codecov Report
:x: Patch coverage is 12.00000% with 22 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 76.55%. Comparing base (b7fb8ed) to head (3462cc6).
:warning: Report is 11 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| internal/datacoord/meta.go | 0.00% | 18 Missing and 3 partials :warning: |
| internal/datacoord/compaction_trigger.go | 75.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #45534 +/- ##
==========================================
- Coverage 76.62% 76.55% -0.08%
==========================================
Files 1870 1870
Lines 290589 290612 +23
==========================================
- Hits 222670 222466 -204
- Misses 60570 60764 +194
- Partials 7349 7382 +33
| Components | Coverage Δ | |
|---|---|---|
| Client | 78.17% <ø> (ø) |
|
| Core | 83.37% <ø> (ø) |
|
| Go | 74.60% <12.00%> (-0.12%) |
:arrow_down: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| internal/datacoord/compaction_trigger.go | 85.79% <75.00%> (-0.13%) |
:arrow_down: |
| internal/datacoord/meta.go | 86.49% <0.00%> (-1.20%) |
:arrow_down: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: czs007, xiaocai2333
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~internal/datacoord/OWNERS~~ [czs007]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@xiaocai2333 cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
/ci-rerun-ut-integration
rerun go-sdk
/ci-rerun-ut-integration
/ci-rerun-ut-integration