milvus
milvus copied to clipboard
enhance:[2.6 cherry pick ] Add zilliz model client
pr: https://github.com/milvus-io/milvus/pull/45168 https://github.com/milvus-io/milvus/issues/35856
@junjiejiangjjj Please associate the related pr of master to the body of your Pull Request. (eg. "pr: #
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm
If you have any questions or requests, please contact @zhikunyao.
[INFO] PR Label Summary by Default [WARNING] No dependent PR reference found
- Target branch '2.6' requires a PR merged to master first
- Please add reference in format 'pr: #number'
[WARNING] Milestone not set
- PR: #45518
- Title: enhance:[2.6 cherry pick ] Add zilliz model client Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
Codecov Report
:x: Patch coverage is 80.66298% with 70 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 76.06%. Comparing base (58f5fdb) to head (f0e56ee).
:warning: Report is 2 commits behind head on 2.6.
Additional details and impacted files
@@ Coverage Diff @@
## 2.6 #45518 +/- ##
==========================================
+ Coverage 73.51% 76.06% +2.54%
==========================================
Files 1344 1878 +534
Lines 208860 291459 +82599
==========================================
+ Hits 153548 221693 +68145
- Misses 48006 62369 +14363
- Partials 7306 7397 +91
| Components | Coverage Δ | |
|---|---|---|
| Client | 78.03% <ø> (ø) |
|
| Core | 82.75% <ø> (∅) |
|
| Go | 74.19% <80.66%> (-0.07%) |
:arrow_down: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| internal/datacoord/import_util.go | 77.60% <100.00%> (+0.03%) |
:arrow_up: |
| internal/proxy/util.go | 78.10% <100.00%> (ø) |
|
| .../util/function/embedding/ali_embedding_provider.go | 81.92% <100.00%> (+0.22%) |
:arrow_up: |
| ...l/function/embedding/bedrock_embedding_provider.go | 82.08% <100.00%> (+0.13%) |
:arrow_up: |
| ...il/function/embedding/cohere_embedding_provider.go | 85.00% <100.00%> (+0.15%) |
:arrow_up: |
| internal/util/function/embedding/function_util.go | 86.66% <ø> (ø) |
|
| ...il/function/embedding/openai_embedding_provider.go | 78.09% <100.00%> (+0.21%) |
:arrow_up: |
| ...nction/embedding/siliconflow_embedding_provider.go | 79.66% <100.00%> (+0.35%) |
:arrow_up: |
| .../util/function/embedding/tei_embedding_provider.go | 86.04% <100.00%> (+0.16%) |
:arrow_up: |
| .../function/embedding/vertexai_embedding_provider.go | 75.83% <100.00%> (+0.16%) |
:arrow_up: |
| ... and 18 more |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: junjiejiangjjj, liliu-z
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [liliu-z]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[INFO] PR Label Summary by Default [SUCCESS] PR #45168 merged to master
- Title: feat: Support zilliz models
- Link: https://github.com/milvus-io/milvus/pull/45168
[WARNING] Milestone not set
- PR: #45518
- Title: enhance:[2.6 cherry pick ] Add zilliz model client Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm
If you have any questions or requests, please contact @zhikunyao.
New changes are detected. LGTM label has been removed.
[INFO] PR Label Summary by Default [SUCCESS] PR #45168 merged to master
- Title: feat: Support zilliz models
- Link: https://github.com/milvus-io/milvus/pull/45168
[WARNING] Milestone not set
- PR: #45518
- Title: enhance:[2.6 cherry pick ] Add zilliz model client Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
[INFO] PR Label Summary by Default [SUCCESS] PR #45168 merged to master
- Title: feat: Support zilliz models
- Link: https://github.com/milvus-io/milvus/pull/45168
[WARNING] Milestone not set
- PR: #45518
- Title: enhance:[2.6 cherry pick ] Add zilliz model client Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
[INFO] PR Label Summary by Default [SUCCESS] PR #45168 merged to master
- Title: feat: Support zilliz models
- Link: https://github.com/milvus-io/milvus/pull/45168
[WARNING] Milestone not set
- PR: #45518
- Title: enhance:[2.6 cherry pick ] Add zilliz model client Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually