milvus
milvus copied to clipboard
milvus-io
fix: [2.5]Fix target segment marked dropped for save stats result twice
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm
If you have any questions or requests, please contact @zhikunyao.
[INFO] PR Label Summary by Default [FAILED] PR #45478 not merged
- Title: fix: Fix target segment marked dropped for save stats result twice
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45478
[WARNING] Milestone not set
- PR: #45480
- Title: fix: [2.5]Fix target segment marked dropped for save stats result twice Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
@xiaocai2333 cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
![mergify[bot] avatar](https://avatars.githubusercontent.com/in/10562?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
:x: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 82.04%. Comparing base (3a7a08f) to head (89a969e).
:warning: Report is 51 commits behind head on 2.5.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| internal/datacoord/meta.go | 84.61% | 1 Missing and 1 partial :warning: |
| internal/datacoord/compaction_trigger.go | 75.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## 2.5 #45480 +/- ##
==========================================
- Coverage 82.10% 82.04% -0.06%
==========================================
Files 1128 1587 +459
Lines 179181 248689 +69508
==========================================
+ Hits 147110 204039 +56929
- Misses 26099 38639 +12540
- Partials 5972 6011 +39
| Components | Coverage Δ | |
|---|---|---|
| Client | 78.90% <22.22%> (-0.06%) |
:arrow_down: |
| Core | 84.56% <79.54%> (∅) |
|
| Go | 82.36% <78.00%> (-0.02%) |
:arrow_down: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| internal/datacoord/task_scheduler.go | 89.95% <100.00%> (+0.04%) |
:arrow_up: |
| internal/datacoord/compaction_trigger.go | 88.47% <75.00%> (-0.15%) |
:arrow_down: |
| internal/datacoord/meta.go | 90.44% <84.61%> (+0.08%) |
:arrow_up: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
[INFO] PR Label Summary by Default [FAILED] PR #45478 not merged
- Title: fix: Fix target segment marked dropped for save stats result twice
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45478
Use /refresh-label to update related check and label manually
@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.
@xiaocai2333 cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
[INFO] PR Label Summary by Default [FAILED] PR #45478 not merged
- Title: fix: Fix target segment marked dropped for save stats result twice
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45478
Use /refresh-label to update related check and label manually
[INFO] PR Label Summary by Default [FAILED] PR #45478 not merged
- Title: fix: Fix target segment marked dropped for save stats result twice
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45478
Use /refresh-label to update related check and label manually
[INFO] PR Label Summary by Refresh-Label
- Title: fix: [2.5]Fix target segment marked dropped for save stats result twice
- Target: 2.5
- Labels: kind/bug, size/M, approved, lgtm, dco-passed, do-not-merge/need-merge-master-first
[SUCCESS] PR #45478 merged to master
- Title: fix: Fix target segment marked dropped for save stats result twice
- Link: https://github.com/milvus-io/milvus/pull/45478
Use /refresh-label to update related check and label manually
@xiaocai2333 cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
@xiaocai2333 cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
@xiaocai2333 cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
@xiaocai2333 cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
@xiaocai2333 cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
@xiaocai2333 cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
[INFO] PR Label Summary by Default [SUCCESS] PR #45478 merged to master
- Title: fix: Fix target segment marked dropped for save stats result twice
- Link: https://github.com/milvus-io/milvus/pull/45478
Use /refresh-label to update related check and label manually
@xiaocai2333 cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
@xiaocai2333 cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: czs007, xiaocai2333
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [czs007]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment