milvus
milvus copied to clipboard
fix: remove validateFieldName in dropIndex
issue: https://github.com/milvus-io/milvus/issues/45459
This check is unnecessary when dropping index.
/lgtm
/lgtm
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm
If you have any questions or requests, please contact @zhikunyao.
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 76.62%. Comparing base (0e1de00) to head (e7c5609).
:warning: Report is 33 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #45460 +/- ##
==========================================
- Coverage 76.66% 76.62% -0.05%
==========================================
Files 1864 1864
Lines 290056 290047 -9
==========================================
- Hits 222384 222260 -124
- Misses 60331 60420 +89
- Partials 7341 7367 +26
| Components | Coverage Δ | |
|---|---|---|
| Client | 78.17% <ø> (ø) |
|
| Core | 83.58% <ø> (ø) |
|
| Go | 74.64% <ø> (-0.06%) |
:arrow_down: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| internal/proxy/task_index.go | 73.85% <ø> (+0.43%) |
:arrow_up: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@SpadeA-Tang cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
@SpadeA-Tang cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
/ci-rerun-ut-integration
/run-cpu-e2e
/ci-rerun-ut-integration
@SpadeA-Tang cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
/ci-rerun-ut-integration
@SpadeA-Tang cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: SpadeA-Tang, zhengbuqian
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~internal/proxy/OWNERS~~ [zhengbuqian]
- ~~tests/OWNERS~~ [zhengbuqian]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/lgtm