milvus icon indicating copy to clipboard operation
milvus copied to clipboard

fix: fix index compatibility after upgrade

Open SpadeA-Tang opened this issue 4 weeks ago • 21 comments

issue: https://github.com/milvus-io/milvus/issues/45380

SpadeA-Tang avatar Nov 07 '25 02:11 SpadeA-Tang

[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm

If you have any questions or requests, please contact @zhikunyao.

sre-ci-robot avatar Nov 07 '25 02:11 sre-ci-robot

@SpadeA-Tang Please associate the related issue to the body of your Pull Request. (eg. "issue: #")

mergify[bot] avatar Nov 07 '25 02:11 mergify[bot]

@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] avatar Nov 07 '25 03:11 mergify[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 83.57%. Comparing base (8b01af5) to head (6b8b08c). :warning: Report is 9 commits behind head on master.

:warning: Current head 6b8b08c differs from pull request most recent head f9b51e9

Please upload reports for the commit f9b51e9 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #45373       +/-   ##
===========================================
+ Coverage   76.62%   83.57%    +6.95%     
===========================================
  Files        1869      518     -1351     
  Lines      290696    80901   -209795     
===========================================
- Hits       222734    67612   -155122     
+ Misses      60619    13289    -47330     
+ Partials     7343        0     -7343     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 83.57% <100.00%> (+0.20%) :arrow_up:
Go ∅ <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/index/IndexFactory.cpp 83.51% <100.00%> (+2.25%) :arrow_up:
internal/core/unittest/test_sealed.cpp 99.67% <100.00%> (+<0.01%) :arrow_up:
...core/unittest/test_utils/indexbuilder_test_utils.h 93.65% <100.00%> (-1.01%) :arrow_down:

... and 1373 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 07 '25 04:11 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SpadeA-Tang, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Nov 11 '25 02:11 sre-ci-robot

@SpadeA-Tang cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 11 '25 05:11 mergify[bot]

/run-cpu-e2e

SpadeA-Tang avatar Nov 12 '25 02:11 SpadeA-Tang

/ci-rerun-ut-integration

SpadeA-Tang avatar Nov 12 '25 02:11 SpadeA-Tang

/ci-rerun-ut-go

SpadeA-Tang avatar Nov 12 '25 02:11 SpadeA-Tang

/ci-rerun-ut-go

SpadeA-Tang avatar Nov 12 '25 03:11 SpadeA-Tang

@SpadeA-Tang cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 12 '25 03:11 mergify[bot]

/run-cpu-e2e

SpadeA-Tang avatar Nov 12 '25 03:11 SpadeA-Tang

@SpadeA-Tang cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 12 '25 06:11 mergify[bot]

/run-cpu-e2e

SpadeA-Tang avatar Nov 12 '25 07:11 SpadeA-Tang

/lgtm

sparknack avatar Nov 12 '25 07:11 sparknack

@SpadeA-Tang cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 12 '25 08:11 mergify[bot]

/run-cpu-e2e

SpadeA-Tang avatar Nov 12 '25 09:11 SpadeA-Tang

@SpadeA-Tang cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 12 '25 10:11 mergify[bot]

/run-cpu-e2e

SpadeA-Tang avatar Nov 12 '25 11:11 SpadeA-Tang

/run-cpu-e2e

SpadeA-Tang avatar Nov 12 '25 11:11 SpadeA-Tang

@SpadeA-Tang cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Nov 12 '25 12:11 mergify[bot]

/run-cpu-e2e

SpadeA-Tang avatar Nov 13 '25 02:11 SpadeA-Tang