milvus
milvus copied to clipboard
enhance: [2.5]Subdivide the CPU slot and memory slot of the tasks
issue: #45186 master pr: #45226
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: xiaocai2333
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[ci-v2-notice] Notice: We are gradually rolling out the new ci-v2 system.
- Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
- Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
- For tests that exist in both v1 and v2, passing in either system is considered PASS.
To rerun ci-v2 checks, comment with:
- /ci-rerun-code-check // for ci-v2/code-check
- /ci-rerun-build // for ci-v2/build
- /ci-rerun-ut-integration // for ci-v2/ut-integration
- /ci-rerun-ut-go // for ci-v2/ut-go
- /ci-rerun-ut-cpp // for ci-v2/ut-cpp
- /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
- /ci-rerun-e2e-arm // for ci-v2/e2e-arm
If you have any questions or requests, please contact @zhikunyao.
[INFO] PR Label Summary by Default [FAILED] PR #45226 not merged
- Title: enhance: Subdivide the CPU slot and memory slot of the tasks
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45226
[WARNING] Milestone not set
- PR: #45305
- Title: enhance: [2.5]Subdivide the CPU slot and memory slot of the tasks Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
[INFO] PR Label Summary by Default [FAILED] PR #45226 not merged
- Title: enhance: Subdivide the CPU slot and memory slot of the tasks
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45226
[WARNING] Milestone not set
- PR: #45305
- Title: enhance: [2.5]Subdivide the CPU slot and memory slot of the tasks Please set a milestone for better release tracking
You can set milestone by commenting:
/set-milestone
Use /refresh-label to update related check and label manually
Codecov Report
:x: Patch coverage is 81.51659% with 39 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 82.05%. Comparing base (3a7a08f) to head (4235a44).
:warning: Report is 61 commits behind head on 2.5.
Additional details and impacted files
@@ Coverage Diff @@
## 2.5 #45305 +/- ##
==========================================
- Coverage 82.10% 82.05% -0.05%
==========================================
Files 1128 1588 +460
Lines 179181 248806 +69625
==========================================
+ Hits 147110 204166 +57056
- Misses 26099 38643 +12544
- Partials 5972 5997 +25
| Components | Coverage Δ | |
|---|---|---|
| Client | 78.90% <22.22%> (-0.06%) |
:arrow_down: |
| Core | 84.53% <70.50%> (∅) |
|
| Go | 82.39% <78.44%> (+0.01%) |
:arrow_up: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| internal/datacoord/index_service.go | 91.01% <100.00%> (ø) |
|
| internal/datacoord/job_manager.go | 71.54% <100.00%> (+0.11%) |
:arrow_up: |
| internal/datacoord/session/indexnode_manager.go | 83.14% <100.00%> (+1.66%) |
:arrow_up: |
| internal/datacoord/task_analyze.go | 87.78% <100.00%> (+0.11%) |
:arrow_up: |
| internal/datacoord/task_index.go | 78.30% <100.00%> (+0.16%) |
:arrow_up: |
| internal/datacoord/task_stats.go | 88.51% <100.00%> (+0.15%) |
:arrow_up: |
| internal/indexnode/indexnode.go | 79.22% <100.00%> (+0.09%) |
:arrow_up: |
| internal/indexnode/indexnode_service.go | 84.16% <100.00%> (+0.32%) |
:arrow_up: |
| internal/indexnode/task_analyze.go | 80.41% <100.00%> (+0.27%) |
:arrow_up: |
| internal/indexnode/task_index.go | 77.85% <100.00%> (+0.16%) |
:arrow_up: |
| ... and 7 more |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
[INFO] PR Label Summary by Default [FAILED] PR #45226 not merged
- Title: enhance: Subdivide the CPU slot and memory slot of the tasks
- Status: OPEN
- Link: https://github.com/milvus-io/milvus/pull/45226
Use /refresh-label to update related check and label manually
@xiaocai2333 cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.
/run-cpu-e2e
/ci-rerun-ut-integration